[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5144: configdrive: fix some failures in tests/component/test_configdrive.py

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5144:
URL: https://github.com/apache/cloudstack/pull/5144#discussion_r657677446



##########
File path: scripts/storage/secondary/createvolume.sh
##########
@@ -135,7 +135,8 @@ create_from_file() {
   local tmpltname=$3
 
   [ -n "$verbose" ] && echo "Moving to $tmpltfs/$tmpltname...could take a while" >&2
-  mv $tmpltimg /$tmpltfs/$tmpltname
+  cp -rf $tmpltimg /$tmpltfs/$tmpltname

Review comment:
       @rhtyd y, mv is faster, however for configdrive ISO, if it is attached to a vm, it will not be recognized in vm after "mv"
   there is no issue if "cp" is used.
   
   I am thinking about (1) not change this script, but copy configdrive ISO in java instead of calling this script (createvolume.sh); (2) detach and re-attach configdrive ISO when it is changed.
   
   this is a draft PR, still WIP.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org