You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Kamal Chandraprakash <ka...@gmail.com> on 2023/12/12 09:00:38 UTC
[VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Hi,
I would like to call a vote for KIP-1007
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception>.
This KIP aims to introduce a new error code for retriable remote storage
errors. Thanks to everyone who reviewed the KIP!
--
Kamal
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Kamal Chandraprakash <ka...@gmail.com>.
Hi all,
While testing the patch [1], realised that introducing a
new REMOTE_STORAGE_NOT_READY error-code
is not compatible with the consumer. Consumer does not retry the FETCH
request for all the retriable
exceptions [2] instead it retries only for specific error codes. Dropping
the KIP-1007
<https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception>
as it is not compatible
with the older clients. Thanks!
[1]: https://github.com/apache/kafka/pull/14822
[2]:
https://sourcegraph.com/github.com/apache/kafka@trunk/-/blob/clients/src/main/java/org/apache/kafka/clients/consumer/internals/FetchCollector.java?L325
On Sun, Jan 7, 2024 at 5:36 PM Kamal Chandraprakash <
kamal.chandraprakash@gmail.com> wrote:
> Thank you for all the votes! I'm closing the vote thread as it is open for
> more than 72 hours.
> The KIP has been passed with 3 binding and 1 non-binding votes.
>
> --
> Kamal
>
>
>
> On Fri, Jan 5, 2024 at 5:51 PM Satish Duggana <sa...@gmail.com>
> wrote:
>
>> Thanks Kamal for the KIP.
>>
>> +1 (binding)
>>
>> On Fri, 5 Jan 2024 at 17:04, Divij Vaidya <di...@gmail.com>
>> wrote:
>> >
>> > +1 (binding)
>> >
>> > --
>> > Divij Vaidya
>> >
>> >
>> >
>> > On Thu, Dec 21, 2023 at 10:30 AM Luke Chen <sh...@gmail.com> wrote:
>> >
>> > > Hi Kamal,
>> > >
>> > > Thanks for the KIP.
>> > > +1 (binding) from me.
>> > >
>> > > Luke
>> > >
>> > > On Thu, Dec 21, 2023 at 4:51 PM Christo Lolov <christololov@gmail.com
>> >
>> > > wrote:
>> > >
>> > > > Heya Kamal,
>> > > >
>> > > > The proposed change makes sense to me as it will be a more explicit
>> > > > behaviour than what Kafka does today - I am happy with it!
>> > > >
>> > > > +1 (non-binding) from me
>> > > >
>> > > > Best,
>> > > > Christo
>> > > >
>> > > > On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
>> > > > kamal.chandraprakash@gmail.com> wrote:
>> > > >
>> > > > > Hi,
>> > > > >
>> > > > > I would like to call a vote for KIP-1007
>> > > > > <
>> > > > >
>> > > >
>> > >
>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
>> > > > > >.
>> > > > > This KIP aims to introduce a new error code for retriable remote
>> > > storage
>> > > > > errors. Thanks to everyone who reviewed the KIP!
>> > > > >
>> > > > > --
>> > > > > Kamal
>> > > > >
>> > > >
>> > >
>>
>
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Kamal Chandraprakash <ka...@gmail.com>.
Thank you for all the votes! I'm closing the vote thread as it is open for
more than 72 hours.
The KIP has been passed with 3 binding and 1 non-binding votes.
--
Kamal
On Fri, Jan 5, 2024 at 5:51 PM Satish Duggana <sa...@gmail.com>
wrote:
> Thanks Kamal for the KIP.
>
> +1 (binding)
>
> On Fri, 5 Jan 2024 at 17:04, Divij Vaidya <di...@gmail.com> wrote:
> >
> > +1 (binding)
> >
> > --
> > Divij Vaidya
> >
> >
> >
> > On Thu, Dec 21, 2023 at 10:30 AM Luke Chen <sh...@gmail.com> wrote:
> >
> > > Hi Kamal,
> > >
> > > Thanks for the KIP.
> > > +1 (binding) from me.
> > >
> > > Luke
> > >
> > > On Thu, Dec 21, 2023 at 4:51 PM Christo Lolov <ch...@gmail.com>
> > > wrote:
> > >
> > > > Heya Kamal,
> > > >
> > > > The proposed change makes sense to me as it will be a more explicit
> > > > behaviour than what Kafka does today - I am happy with it!
> > > >
> > > > +1 (non-binding) from me
> > > >
> > > > Best,
> > > > Christo
> > > >
> > > > On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
> > > > kamal.chandraprakash@gmail.com> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > I would like to call a vote for KIP-1007
> > > > > <
> > > > >
> > > >
> > >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
> > > > > >.
> > > > > This KIP aims to introduce a new error code for retriable remote
> > > storage
> > > > > errors. Thanks to everyone who reviewed the KIP!
> > > > >
> > > > > --
> > > > > Kamal
> > > > >
> > > >
> > >
>
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Satish Duggana <sa...@gmail.com>.
Thanks Kamal for the KIP.
+1 (binding)
On Fri, 5 Jan 2024 at 17:04, Divij Vaidya <di...@gmail.com> wrote:
>
> +1 (binding)
>
> --
> Divij Vaidya
>
>
>
> On Thu, Dec 21, 2023 at 10:30 AM Luke Chen <sh...@gmail.com> wrote:
>
> > Hi Kamal,
> >
> > Thanks for the KIP.
> > +1 (binding) from me.
> >
> > Luke
> >
> > On Thu, Dec 21, 2023 at 4:51 PM Christo Lolov <ch...@gmail.com>
> > wrote:
> >
> > > Heya Kamal,
> > >
> > > The proposed change makes sense to me as it will be a more explicit
> > > behaviour than what Kafka does today - I am happy with it!
> > >
> > > +1 (non-binding) from me
> > >
> > > Best,
> > > Christo
> > >
> > > On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
> > > kamal.chandraprakash@gmail.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > I would like to call a vote for KIP-1007
> > > > <
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
> > > > >.
> > > > This KIP aims to introduce a new error code for retriable remote
> > storage
> > > > errors. Thanks to everyone who reviewed the KIP!
> > > >
> > > > --
> > > > Kamal
> > > >
> > >
> >
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Divij Vaidya <di...@gmail.com>.
+1 (binding)
--
Divij Vaidya
On Thu, Dec 21, 2023 at 10:30 AM Luke Chen <sh...@gmail.com> wrote:
> Hi Kamal,
>
> Thanks for the KIP.
> +1 (binding) from me.
>
> Luke
>
> On Thu, Dec 21, 2023 at 4:51 PM Christo Lolov <ch...@gmail.com>
> wrote:
>
> > Heya Kamal,
> >
> > The proposed change makes sense to me as it will be a more explicit
> > behaviour than what Kafka does today - I am happy with it!
> >
> > +1 (non-binding) from me
> >
> > Best,
> > Christo
> >
> > On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
> > kamal.chandraprakash@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > I would like to call a vote for KIP-1007
> > > <
> > >
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
> > > >.
> > > This KIP aims to introduce a new error code for retriable remote
> storage
> > > errors. Thanks to everyone who reviewed the KIP!
> > >
> > > --
> > > Kamal
> > >
> >
>
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Luke Chen <sh...@gmail.com>.
Hi Kamal,
Thanks for the KIP.
+1 (binding) from me.
Luke
On Thu, Dec 21, 2023 at 4:51 PM Christo Lolov <ch...@gmail.com>
wrote:
> Heya Kamal,
>
> The proposed change makes sense to me as it will be a more explicit
> behaviour than what Kafka does today - I am happy with it!
>
> +1 (non-binding) from me
>
> Best,
> Christo
>
> On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
> kamal.chandraprakash@gmail.com> wrote:
>
> > Hi,
> >
> > I would like to call a vote for KIP-1007
> > <
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
> > >.
> > This KIP aims to introduce a new error code for retriable remote storage
> > errors. Thanks to everyone who reviewed the KIP!
> >
> > --
> > Kamal
> >
>
Re: [VOTE] KIP-1007: Introduce Remote Storage Not Ready Exception
Posted by Christo Lolov <ch...@gmail.com>.
Heya Kamal,
The proposed change makes sense to me as it will be a more explicit
behaviour than what Kafka does today - I am happy with it!
+1 (non-binding) from me
Best,
Christo
On Tue, 12 Dec 2023 at 09:01, Kamal Chandraprakash <
kamal.chandraprakash@gmail.com> wrote:
> Hi,
>
> I would like to call a vote for KIP-1007
> <
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1007%3A+Introduce+Remote+Storage+Not+Ready+Exception
> >.
> This KIP aims to introduce a new error code for retriable remote storage
> errors. Thanks to everyone who reviewed the KIP!
>
> --
> Kamal
>