You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by hyunsik <gi...@git.apache.org> on 2014/10/07 23:45:53 UTC

[GitHub] tajo pull request: TAJO-1104: Using asterisk with GROUP BY causes ...

GitHub user hyunsik opened a pull request:

    https://github.com/apache/tajo/pull/187

    TAJO-1104: Using asterisk with GROUP BY causes NPE.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/hyunsik/tajo TAJO-1104

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tajo/pull/187.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #187
    
----
commit c0de5455df3d7fdce7fa4c39ddd7c20623614e6f
Author: Hyunsik Choi <hy...@apache.org>
Date:   2014-10-07T21:44:49Z

    TAJO-1104: Using asterisk with GROUP BY causes NPE.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1104: Using asterisk with GROUP BY causes ...

Posted by blrunner <gi...@git.apache.org>.
Github user blrunner commented on the pull request:

    https://github.com/apache/tajo/pull/187#issuecomment-58301849
  
    +1
    
    Thanks @hyunsik.
    The patch looks good to me and 'mvn clean install' finished successfully.
    Push it!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1104: Using asterisk with GROUP BY causes ...

Posted by hyunsik <gi...@git.apache.org>.
Github user hyunsik commented on the pull request:

    https://github.com/apache/tajo/pull/187#issuecomment-58268495
  
    This patch includes some refactoring to move query validation methods to QueryTestCaseBase. In addition, it includes a bug fix for TAJO-1098.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tajo pull request: TAJO-1104: Using asterisk with GROUP BY causes ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/tajo/pull/187


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---