[jira] [Commented] (DRILL-6318) Push down limit past flatten is incorrect

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-6318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431919#comment-16431919 ] 

ASF GitHub Bot commented on DRILL-6318:
---------------------------------------

GitHub user oleg-zinovev opened a pull request:

    https://github.com/apache/drill/pull/1204

    DRILL-6318

    Test for DRILL-6099 was changed due it's incorrect behavior 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/oleg-zinovev/drill drill-6318

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/1204.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1204
    
----
commit 5a6c96240d8e7d0409481f63036d63b572fe4d26
Author: Oleg <oz...@...>
Date:   2018-04-10T08:26:25Z

    DRILL-6318

----


> Push down limit past flatten is incorrect
> -----------------------------------------
>
>                 Key: DRILL-6318
>                 URL: https://issues.apache.org/jira/browse/DRILL-6318
>             Project: Apache Drill
>          Issue Type: Bug
>    Affects Versions: 1.13.0, 1.14.0
>         Environment: Ubuntu Mate 18.04
> Apache Drill 1.14.0-SNAPSHOT
>            Reporter: Oleg Zinoviev
>            Priority: Major
>         Attachments: sample.json
>
>
> Sample data: [^sample.json]
> Result of
> {code:sql}
> select flatten(data) as d from dfs.root.`sample.json`
> {code}
> is
> ||d||
> |Honored Boy Scout|
> |Yawning Wolf|
> |Closed Queen|
> |Innocent Volunteer|
> |Junior Wing|
> |Lame Mantis|
> |Old Master|
> |Numb Pawn|
> |Hollow Guardian|
> |Twin Hurricane|
> |Helpless Avalange|
> Let's try to get first 3 rows:
> {code:sql}
> select flatten(data) as d from dfs.root.`sample.json` limit 3
> {code}
> Result has only 2 rows:
> ||d||
> |Honored Boy Scout|
> |Yawning Wolf|
> *Reason:* Limit was pushed down below flatten and only 3 top rows from json was selected. In this 3 rows only 2nd has items in "data" field.
> Let's try to get 3 rows from the middle:
> {code:sql}
> select flatten(data) as d from dfs.root.`sample.json` limit 3 offset 5
> {code}
> Result is empty.
> *Reason:* Limit and offset was pushed down below flatten and only 6, 7 and 8 row from json was selected. This 3 rows contains only 3 items in "data" field. After flatten limit and offset applies second time and reject all select items.
> Error in org/apache/drill/exec/planner/logical/DrillPushLimitToScanRule.java



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)