You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/03/26 05:43:38 UTC
[GitHub] [groovy] armeris opened a new pull request #1206: Added DOCTYPE tag
and "lang" attribute
armeris opened a new pull request #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206
Fix for https://sonarcloud.io/project/issues?id=apache_groovy&open=AXD-_jqMDC9Fk2pZiWTt&resolved=false&types=BUG
Added missing tag and attribute in package.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605434092
Agreed. No harm in merging. I was just holding off in case the preferred way to fix was to remove package.html and replace with package-info.java.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] armeris commented on issue #1206: Added DOCTYPE tag and
"lang" attribute
Posted by GitBox <gi...@apache.org>.
armeris commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605325724
I used JDK 1.8 which is a bit old, the issue could be there. I will try with a newer version to see if it is working properly or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] armeris commented on issue #1206: Added DOCTYPE tag and
"lang" attribute
Posted by GitBox <gi...@apache.org>.
armeris commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-604930812
Um I wasn't aware of that. Maybe if this info is not going to appear anymore this file should be removed or if it is needed it should be added to the javadoc again.
In anycase these changes goes beyond the objective of this bugix and a issue should be reported with this.
Talking about the PR itself, I don't know why travis is failing, it seems that is because this error:
`java.lang.IllegalStateException: You're not authorized to run analysis. Please contact the project administrator.`
Is a special permission or anything needed to run travis?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-604533613
The suggested change looks good. I am just wondering whether the expectations of the javadoc tool have changed. The package description doesn't seem to appear in the javadoc at the moment:
https://docs.groovy-lang.org/latest/html/api/groovy/inspect/package-summary.html
(it is appearing in the groovydoc)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605618298
FYI, the issue with package.html has been fixed. From JDK9+, javadoc requires sourcepath to be set or the base source directory containing package.html files to be on the classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] armeris commented on issue #1206: Added DOCTYPE tag and
"lang" attribute
Posted by GitBox <gi...@apache.org>.
armeris commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-604978025
I just have build the doc in the master branch and it is appearing both in groovydoc and in javadoc. Maybe a specific bug of 3.0.x version?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-604957019
We'd like the information to appear. We'll need to track down why it isn't. It appears here:
https://docs.groovy-lang.org/3.0.0/html/api/groovy/inspect/package-summary.html
but not here (or 3.0.2):
https://docs.groovy-lang.org/3.0.1/html/api/groovy/inspect/package-summary.html
I'll check if we have made any changes (I don't remember any), otherwise we'll need to look for any gradle or java changes in that area.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert edited a comment on issue #1206: Added DOCTYPE
tag and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert edited a comment on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605618298
FYI, the issue with package.html not being processed for JDK9+ has been fixed. From JDK9+, javadoc requires sourcepath to be set or the base source directory containing package.html files to be on the classpath.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 merged pull request #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
danielsun1106 merged pull request #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605431366
The package description issue is not related to the PR.
Merged. Thanks for your contribution!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #1206: Added DOCTYPE tag
and "lang" attribute
Posted by GitBox <gi...@apache.org>.
paulk-asert commented on issue #1206: Added DOCTYPE tag and "lang" attribute
URL: https://github.com/apache/groovy/pull/1206#issuecomment-605323499
I am thinking different JDKs. Which version did you use?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services