[GitHub] jihoonson commented on a change in pull request #5688: move rangeSet compare into shardspec

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #5688: move rangeSet compare into shardspec
URL: https://github.com/apache/incubator-druid/pull/5688#discussion_r205255158
 
 

 ##########
 File path: processing/src/main/java/io/druid/query/filter/DimFilterUtils.java
 ##########
 @@ -122,16 +122,19 @@
       boolean include = true;
 
       if (dimFilter != null && shard != null) {
-        Map<String, RangeSet<String>> domain = shard.getDomain();
-        for (Map.Entry<String, RangeSet<String>> entry : domain.entrySet()) {
-          String dimension = entry.getKey();
+        Map<String, RangeSet<String>> filterDomain = Maps.newHashMap();
 
 Review comment:
   nit: there's no point to use the Guava API. Please use `new HashMap<>()` instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org