[GitHub] [hbase] saintstack commented on a change in pull request #760: HBASE-23218 Increase the flexibility of replication walentry filter interface

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #760: HBASE-23218 Increase the flexibility of replication walentry filter interface
URL: https://github.com/apache/hbase/pull/760#discussion_r340831359
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/WALEntrySinkFilter.java
 ##########
 @@ -51,9 +51,8 @@
   void init(AsyncConnection conn);
 
   /**
-   * @param table Table edit is destined for.
-   * @param writeTime Time at which the edit was created on the source.
+   * @param entry WALEntry.
    * @return True if we are to filter out the edit.
    */
-  boolean filter(TableName table, long writeTime);
+  boolean filter(WALEntry entry);
 
 Review comment:
   Yes, what @anoopsjohn  said. We don't want PBs in our API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services