You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "kimyenac (via GitHub)" <gi...@apache.org> on 2026/07/20 08:55:21 UTC

[PR] [ZEPPELIN-6443] Avoid misleading elapsed-time footer when a running paragraph has no dateStarted [zeppelin]

kimyenac opened a new pull request, #5330:
URL: https://github.com/apache/zeppelin/pull/5330

   ### What is this PR for?
   
   The Angular paragraph footer fell back to `new Date()` when `dateStarted` was undefined for a running paragraph, which rendered a misleading `Started less than a minute ago.` message — implying the run had just started when the real start time was simply unknown (a race where the paragraph is `RUNNING` before `dateStarted` is populated).
   
   This PR shows a neutral `Running…` label instead when the start time is unknown, and keeps the existing `Started X ago.` output when `dateStarted` is present. The same bug/fix applies to the React `ParagraphFooter` twin, and a unit test is added there for the missing-`dateStarted` case (the Angular project has no unit-test setup).
   
   The pre-existing `TODO(hsuanxyz) dateStarted undefined after start` is resolved.
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/ZEPPELIN-6443
   
   ### How should this be tested?
   
   - `cd zeppelin-web-angular && npm run lint`
   - React unit tests: `cd zeppelin-web-angular/projects/zeppelin-react && npm test` (covers the `Running…` / missing-`dateStarted` case)
   - Manually: run a paragraph and confirm the running (elapsed-time) and finished (execution-time) footers still render correctly.
   
   ### Screenshots (if appropriate)
   
   N/A
   
   ### Questions:
   
   - Does the licenses files need to update? No
   - Is there breaking changes for older versions? No
   - Does this needs documentation? No
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6443] Avoid misleading elapsed-time footer when a running paragraph has no dateStarted [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha commented on PR #5330:
URL: https://github.com/apache/zeppelin/pull/5330#issuecomment-5035642594

   Merged into master (52397c8c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6443] Avoid misleading elapsed-time footer when a running paragraph has no dateStarted [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha merged PR #5330:
URL: https://github.com/apache/zeppelin/pull/5330


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org