You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/06/23 23:52:21 UTC
[kudu-CR] cmake: Remove RESOURCE LOCK "master-rpc-ports"
Hello Adar Dembo, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/7288
to review the following change.
Change subject: cmake: Remove RESOURCE_LOCK "master-rpc-ports"
......................................................................
cmake: Remove RESOURCE_LOCK "master-rpc-ports"
With unique loopback addresses supported for master servers, we no
longer need this resource lock.
Also clean up a couple messy spots.
This patch doesn't remove RUN_SERIAL because those are typically used
for things like stress tests, benchmarks, and other tests that are
resource hogs and may cause timeouts in other tests due to that resource
consumption.
Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/tools/CMakeLists.txt
2 files changed, 12 insertions(+), 15 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/7288/1
--
To view, visit http://gerrit.cloudera.org:8080/7288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] cmake: Remove RESOURCE LOCK "master-rpc-ports"
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: cmake: Remove RESOURCE_LOCK "master-rpc-ports"
......................................................................
Patch Set 1:
OK. I am going to just abandon this patch since it's not really that important. But we should keep in mind that we can optimize the Linux non-Jenkins ctest run after merging the ancestor patches.
--
To view, visit http://gerrit.cloudera.org:8080/7288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] cmake: Remove RESOURCE LOCK "master-rpc-ports"
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: cmake: Remove RESOURCE_LOCK "master-rpc-ports"
......................................................................
Patch Set 1:
> Uploaded patch set 1.
AFAIK, unique loopback addresses are not supported on OS X. Maybe, make usage of that 'master-rpc-ports' resource lock dependent on OS the tests are running?
--
To view, visit http://gerrit.cloudera.org:8080/7288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] cmake: Remove RESOURCE LOCK "master-rpc-ports"
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: cmake: Remove RESOURCE_LOCK "master-rpc-ports"
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] cmake: Remove RESOURCE LOCK "master-rpc-ports"
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: cmake: Remove RESOURCE_LOCK "master-rpc-ports"
......................................................................
Patch Set 1:
> > Uploaded patch set 1.
>
> AFAIK, unique loopback addresses are not supported on OS X. Maybe,
> make usage of that 'master-rpc-ports' resource lock dependent on OS
> the tests are running?
I (ruefully) agree with Alexey; we should probably retain it, but condition it on macOS only.
--
To view, visit http://gerrit.cloudera.org:8080/7288
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3eacc1268d952bd09ddb5a3ac495e603cd0474b8
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No