You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2007/12/07 20:22:07 UTC
feature request: check for valid property values
Hi,
A user reported a problem on the TSVN mailing list which he encountered
after setting the svn:eol-style property but leaving the value empty:
http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535
I know I could check for such invalid values myself in TSVN, but I think
this should be done in the library - after all only the svn library
really knows what it considers valid and what not.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: feature request: check for valid property values
Posted by David Glasser <gl...@davidglasser.net>.
On Dec 7, 2007 2:03 PM, Daniel Rall <dl...@collab.net> wrote:
> On Fri, 07 Dec 2007, Stefan Küng wrote:
>
> > Hi,
> >
> > A user reported a problem on the TSVN mailing list which he encountered
> > after setting the svn:eol-style property but leaving the value empty:
> > http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535
> >
> > I know I could check for such invalid values myself in TSVN, but I think
> > this should be done in the library - after all only the svn library
> > really knows what it considers valid and what not.
>
> Current behavior:
>
> $ svn ps svn:eol-style BLLOOOG COMMITTERS
> property 'svn:eol-style' set on 'COMMITTERS'
>
>
> Proposed behavior:
>
> $ ./subversion/svn/svn ps svn:eol-style BLLOOOG COMMITTERS
> subversion/libsvn_wc/props.c:2610: (apr_err=135001)
> svn: Unrecognized line ending style for 'COMMITTERS'
+1 on feature and patch.
--dave
--
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: feature request: check for valid property values
Posted by Daniel Rall <dl...@collab.net>.
On Fri, 07 Dec 2007, Daniel Rall wrote:
> Committed to trunk in r28331, and nominated for backport to 1.4.x.
Backported to the 1.4.x branch in r28338. This fix will appear in 1.4.6.
--
Daniel Rall
Re: feature request: check for valid property values
Posted by Daniel Rall <dl...@collab.net>.
Committed to trunk in r28331, and nominated for backport to 1.4.x.
Re: feature request: check for valid property values
Posted by Ben Collins-Sussman <su...@gmail.com>.
Ship it!
On Dec 7, 2007, at 3:18 PM, Stefan Küng <to...@gmail.com> wrote:
> Daniel Rall wrote:
>> On Fri, 07 Dec 2007, Stefan Küng wrote:
>>> Hi,
>>>
>>> A user reported a problem on the TSVN mailing list which he
>>> encountered after setting the svn:eol-style property but leaving
>>> the value empty:
>>> http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535
>>>
>>> I know I could check for such invalid values myself in TSVN, but I
>>> think this should be done in the library - after all only the svn
>>> library really knows what it considers valid and what not.
>> Current behavior:
>> $ svn ps svn:eol-style BLLOOOG COMMITTERS property 'svn:eol-style'
>> set on 'COMMITTERS'
>> Proposed behavior:
>> $ ./subversion/svn/svn ps svn:eol-style BLLOOOG COMMITTERS
>> subversion/libsvn_wc/props.c:2610: (apr_err=135001)
>> svn: Unrecognized line ending style for 'COMMITTERS'
>
> Great!
>
> Patch looks good, but I am maybe not the one qualified to comment on
> that.
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest Interface to (Sub)Version Control
> /_/ \_\ http://tortoisesvn.net
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: feature request: check for valid property values
Posted by Stefan Küng <to...@gmail.com>.
Daniel Rall wrote:
> On Fri, 07 Dec 2007, Stefan Küng wrote:
>
>> Hi,
>>
>> A user reported a problem on the TSVN mailing list which he encountered
>> after setting the svn:eol-style property but leaving the value empty:
>> http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535
>>
>> I know I could check for such invalid values myself in TSVN, but I think
>> this should be done in the library - after all only the svn library
>> really knows what it considers valid and what not.
>
> Current behavior:
>
> $ svn ps svn:eol-style BLLOOOG COMMITTERS
> property 'svn:eol-style' set on 'COMMITTERS'
>
>
> Proposed behavior:
>
> $ ./subversion/svn/svn ps svn:eol-style BLLOOOG COMMITTERS
> subversion/libsvn_wc/props.c:2610: (apr_err=135001)
> svn: Unrecognized line ending style for 'COMMITTERS'
Great!
Patch looks good, but I am maybe not the one qualified to comment on that.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: feature request: check for valid property values
Posted by Daniel Rall <dl...@collab.net>.
On Fri, 07 Dec 2007, Stefan Küng wrote:
> Hi,
>
> A user reported a problem on the TSVN mailing list which he encountered
> after setting the svn:eol-style property but leaving the value empty:
> http://tortoisesvn.tigris.org/servlets/ReadMsg?list=users&msgNo=8535
>
> I know I could check for such invalid values myself in TSVN, but I think
> this should be done in the library - after all only the svn library
> really knows what it considers valid and what not.
Current behavior:
$ svn ps svn:eol-style BLLOOOG COMMITTERS
property 'svn:eol-style' set on 'COMMITTERS'
Proposed behavior:
$ ./subversion/svn/svn ps svn:eol-style BLLOOOG COMMITTERS
subversion/libsvn_wc/props.c:2610: (apr_err=135001)
svn: Unrecognized line ending style for 'COMMITTERS'