You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by jm...@apache.org on 2004/09/08 01:34:46 UTC
cvs commit: jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl CollectionResourcesBase.java WebappXMLResources.java ResourcesBase.java JDBCResources.java BasicMessageList.java
jmitchell 2004/09/07 16:34:46
Modified: resources/src/java/org/apache/commons/resources/impl
CollectionResourcesBase.java
WebappXMLResources.java ResourcesBase.java
JDBCResources.java BasicMessageList.java
Log:
Add comments that need clarification or documentation
Revision Changes Path
1.13 +5 -3 jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/CollectionResourcesBase.java
Index: CollectionResourcesBase.java
===================================================================
RCS file: /home/cvs/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/CollectionResourcesBase.java,v
retrieving revision 1.12
retrieving revision 1.13
diff -u -r1.12 -r1.13
--- CollectionResourcesBase.java 27 Mar 2004 21:34:09 -0000 1.12
+++ CollectionResourcesBase.java 7 Sep 2004 23:34:46 -0000 1.13
@@ -141,6 +141,8 @@
* @exception ResourcesKeyException if the no value for the specified
* key was found, and <code>isReturnNull()</code> returns
* <code>false</code>
+ *
+ * @TODO - FIXME - timeZone is ignored
*/
public Object getObject(String key, Locale locale, TimeZone timeZone) {
1.11 +4 -4 jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/WebappXMLResources.java
Index: WebappXMLResources.java
===================================================================
RCS file: /home/cvs/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/WebappXMLResources.java,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- WebappXMLResources.java 27 Mar 2004 21:34:09 -0000 1.10
+++ WebappXMLResources.java 7 Sep 2004 23:34:46 -0000 1.11
@@ -189,7 +189,7 @@
try {
stream.close();
} catch (Exception e) {
- ;
+ // standard io
}
stream = null;
}
1.12 +6 -6 jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/ResourcesBase.java
Index: ResourcesBase.java
===================================================================
RCS file: /home/cvs/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/ResourcesBase.java,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -r1.11 -r1.12
--- ResourcesBase.java 27 Mar 2004 21:34:09 -0000 1.11
+++ ResourcesBase.java 7 Sep 2004 23:34:46 -0000 1.12
@@ -107,7 +107,7 @@
*/
public void init() throws ResourcesException {
- ; // The default implementation does nothing
+ // The default implementation does nothing
}
@@ -124,7 +124,7 @@
*/
public void destroy() throws ResourcesException {
- ; // The default implementation does nothing
+ // The default implementation does nothing
}
@@ -318,7 +318,7 @@
Object value = getObject(key, locale, timeZone);
if (value == null) {
- return ((String) null);
+ return (null);
} else if (value instanceof String) {
return ((String) value);
} else {
1.2 +4 -5 jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/JDBCResources.java
Index: JDBCResources.java
===================================================================
RCS file: /home/cvs/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/JDBCResources.java,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -r1.1 -r1.2
--- JDBCResources.java 11 Jun 2004 02:43:48 -0000 1.1
+++ JDBCResources.java 7 Sep 2004 23:34:46 -0000 1.2
@@ -223,7 +223,6 @@
String user = connectionProps.getProperty("jdbc.connect.login");
String pass = connectionProps.getProperty("jdbc.connect.password");
- String db = connectionProps.getProperty("jdbc.sql.db");
String table = connectionProps.getProperty("jdbc.sql.table");
String localeColumn = connectionProps.getProperty("jdbc.sql.locale.column");
String keyColumn = connectionProps.getProperty("jdbc.sql.key.column");
1.14 +5 -3 jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/BasicMessageList.java
Index: BasicMessageList.java
===================================================================
RCS file: /home/cvs/jakarta-commons-sandbox/resources/src/java/org/apache/commons/resources/impl/BasicMessageList.java,v
retrieving revision 1.13
retrieving revision 1.14
diff -u -r1.13 -r1.14
--- BasicMessageList.java 27 Mar 2004 21:34:09 -0000 1.13
+++ BasicMessageList.java 7 Sep 2004 23:34:46 -0000 1.14
@@ -105,6 +105,8 @@
*
* @param globalMessageKey The new default global message key
* @param messages The messages to be initially added to this object.
+ *
+ * @TODO - FIXME - globalMessageKey is ignored
*/
public BasicMessageList(String globalMessageKey, MessageList messages) {
super();
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org