You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "ydyzxm (via GitHub)" <gi...@apache.org> on 2023/02/28 11:18:13 UTC
[GitHub] [skywalking] ydyzxm opened a new issue, #10463: [Bug] OAP TTL Slave table not deleted
ydyzxm opened a new issue, #10463:
URL: https://github.com/apache/skywalking/issues/10463
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar issues.
### Apache SkyWalking Component
OAP server (apache/skywalking)
### What happened
DataTTLKeeperTimer During the scheduled task, only data in the primary table is deleted. Data in the secondary table is not deleted. As a result, the data store is too large for a long time
### What you expected to happen
When the primary table is deleted, data in the secondary table is also deleted
### How to reproduce
If the segment data is reported, both the segment table and the segment_tag table are written into the segment table. However, when a scheduled task is deleted, only the segment data is deleted
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ydyzxm commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "ydyzxm (via GitHub)" <gi...@apache.org>.
ydyzxm commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448017574
9.2.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1449171113
> no，slave tables don't have time_bucket，delete By id
I don't know what do you mean, JDBC TTL don't have delete By id logic.
> If you add time_bucket field from slave table, the change is significant and you may have to change everything from table creation to query presentation
9.2 slave table should have time_bucket column , please check the fix #9508
Did you follow the change log upgrade your OAP?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ydyzxm commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "ydyzxm (via GitHub)" <gi...@apache.org>.
ydyzxm commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448021488
use mysql ：H2HistoryDeleteDAO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ydyzxm commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "ydyzxm (via GitHub)" <gi...@apache.org>.
ydyzxm commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1449148968
If you add time_bucket field from slave table, the change is significant and you may have to change everything from table creation to query presentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448014396
Could you please share which version you use, there's a bug fixed before: https://github.com/apache/skywalking/pull/9508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ydyzxm commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "ydyzxm (via GitHub)" <gi...@apache.org>.
ydyzxm commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1449147210
no，slave tables don't have time_bucket，delete By id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448008040
@wankai123 Could you confirm this? I just want to confirm and don't need to fix as all are going to be changed.
@kezhenxu94 Let's notice this in new implementations.
@ydyzxm See #10366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wankai123 commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448031296
Can you check the slave tables have `time_bucket` column?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1449177051
@kezhenxu94 will finish the new design implementation in 9.4.0. Generally, we don't have to follow this no matter it was fixed.
@ydyzxm I will close this, if you want to dig deeper, try the latest with a new env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed issue #10463: [Bug] OAP TTL Slave table not deleted
URL: https://github.com/apache/skywalking/issues/10463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] ydyzxm commented on issue #10463: [Bug] OAP TTL Slave table not deleted
Posted by "ydyzxm (via GitHub)" <gi...@apache.org>.
ydyzxm commented on issue #10463:
URL: https://github.com/apache/skywalking/issues/10463#issuecomment-1448020898
user mysql ：H2HistoryDeleteDAO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org