[GitHub] [ozone] sodonnel commented on a change in pull request #2401: EC: Make ECReplicationConfig stored as bucket level attributes.

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2401:
URL: https://github.com/apache/ozone/pull/2401#discussion_r669499527



##########
File path: hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/BucketArgs.java
##########
@@ -89,6 +91,36 @@ private BucketArgs(Boolean versioning, StorageType storageType,
     this.quotaInNamespace = quotaInNamespace;
   }
 
+  /**
+   * Private constructor, constructed via builder.
+   * @param versioning Bucket version flag.
+   * @param storageType Storage type to be used.
+   * @param acls list of ACLs.
+   * @param metadata map of bucket metadata
+   * @param bucketEncryptionKey bucket encryption key name
+   * @param sourceVolume
+   * @param sourceBucket
+   * @param quotaInBytes Bucket quota in bytes.
+   * @param quotaInNamespace Bucket quota in counts.
+   */
+  @SuppressWarnings("parameternumber")
+  private BucketArgs(Boolean versioning, StorageType storageType,
+      List<OzoneAcl> acls, Map<String, String> metadata,
+      String bucketEncryptionKey, String sourceVolume, String sourceBucket,
+      long quotaInBytes, long quotaInNamespace,
+      ECReplicationConfig ecReplicationConfig) {
+    this.acls = acls;
+    this.versioning = versioning;
+    this.storageType = storageType;
+    this.metadata = metadata;
+    this.bucketEncryptionKey = bucketEncryptionKey;
+    this.sourceVolume = sourceVolume;
+    this.sourceBucket = sourceBucket;
+    this.quotaInBytes = quotaInBytes;
+    this.quotaInNamespace = quotaInNamespace;
+    this.ecReplicationConfig = ecReplicationConfig;
+  }
+

Review comment:
       This constructor is private, so I think we can just add another parameter rather than duplicating?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org