[GitHub] [incubator-iceberg] rdsr commented on issue #244: [WIP] Add new Update schema API to support adding of all new fields detected based on a companion schema

[GitBox <gi...@apache.org>]

rdsr commented on issue #244: [WIP] Add new Update schema API to support adding of all new fields detected based on a companion schema
URL: https://github.com/apache/incubator-iceberg/pull/244#issuecomment-541378851
 
 
   @fbocse are you still planning to work on this task?
   
   We had a similar requirement. My changes are specified here: https://github.com/rdsr/incubator-iceberg/commit/b6810ea51fa8ad8394b53586fe47f8dcde6753ac
   
   I used your tests as base and kept the same user facing api as yours.
   My approach is slightly different though. I've implemented two visitors
   
   First visitor traverses the updated schema and checks for additions and updates. In updates it also checks for renames, type widening, and documentation updates
   
   Second visitor traverses the existing schema and checks for deletes in the updated schema.
   
   Let me know what you guys think @rdblue  and @fbocse ! If you guys feel this approach is workable I'll create a PR from this
   
   
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org