[jira] [Resolved] (THRIFT-2560) Thrift compiler generator tries to concat ints with strings using +

["Jens Geyer (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/THRIFT-2560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jens Geyer resolved THRIFT-2560.
--------------------------------

    Resolution: Fixed

What a statement! George Bernard Shaw said it best: "_The reasonable man adapts himself to the world: the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man_".

Committed.

> Thrift compiler generator tries to concat ints with strings using +
> -------------------------------------------------------------------
>
>                 Key: THRIFT-2560
>                 URL: https://issues.apache.org/jira/browse/THRIFT-2560
>             Project: Thrift
>          Issue Type: Bug
>          Components: C# - Compiler, Compiler (General), Delphi - Compiler
>    Affects Versions: 0.9.1
>         Environment: all
>            Reporter: Jens Geyer
>            Assignee: Jens Geyer
>            Priority: Minor
>             Fix For: 0.9.2
>
>         Attachments: THRIFT-2560-Thrift-compiler-generator-tries-to-conca-V2.patch
>
>
> As reported in THRIFT-2558, at several places in the Thrift language code generators an attenpt is made to throw a string by adding a string literal ("") and an int (t_base_type::t_base) in several places:
> {code}
> throw "compiler error: no C# name for base type " + tbase->get_base();
> {code}
> Additionally, at several places a wrong language name in these eror messages is used, probably due to the fact that most code generators are implemented re-using another, similar language's code generator.



--
This message was sent by Atlassian JIRA
(v6.2#6252)