[GitHub] [pinot] walterddr commented on a diff in pull request #11208: [multistage] support the rest of the agg functions currently implementable

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #11208:
URL: https://github.com/apache/pinot/pull/11208#discussion_r1278062621


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/AggregationFunctionType.java:
##########
@@ -86,23 +87,32 @@ public enum AggregationFunctionType {
   DISTINCTCOUNTHLL("distinctCountHLL", ImmutableList.of("DISTINCT_COUNT_HLL"), SqlKind.OTHER_FUNCTION,
       SqlFunctionCategory.USER_DEFINED_FUNCTION, OperandTypes.ANY, ReturnTypes.BIGINT,
       ReturnTypes.explicit(SqlTypeName.OTHER)),
-  DISTINCTCOUNTRAWHLL("distinctCountRawHLL"),
-  DISTINCTCOUNTSMARTHLL("distinctCountSmartHLL"),
+  DISTINCTCOUNTRAWHLL("distinctCountRawHLL", ImmutableList.of("DISTINCT_COUNT_RAW_HLL"), SqlKind.OTHER_FUNCTION,

Review Comment:
   test needed for optional 2nd argument about HLL log2m size



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org