You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yida Wu (Code Review)" <ge...@cloudera.org> on 2024/08/01 06:38:10 UTC

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Yida Wu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21628


Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................

IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Added testcases to run TPC-H and TPC-DS queries twice with tuple
caching to verify that Impala won't crash and ensure the
correctness of the results.

Testcases allows mt_dop to be 0 or 4.

Also, added the environment varibles of tuple cache to
run-all-tests.sh and added skipif to test_tuple_cache_tpc_queries.py
to skip if not tuple cache enabled.

Tests:
Ran the tests in the build with tuple cache enabled.

Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
---
M bin/run-all-tests.sh
M tests/common/environ.py
M tests/common/skip.py
A tests/query_test/test_tuple_cache_tpc_queries.py
M tests/util/test_file_parser.py
5 files changed, 133 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/21628/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................

IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Added testcases to run TPC-H and TPC-DS queries twice with tuple
caching to verify that Impala won't crash and ensure the
correctness of the results.

Testcases allows mt_dop to be 0 or 4.

Also, added the environment varibles of tuple cache to
run-all-tests.sh and added skipif to test_tuple_cache_tpc_queries.py
to skip if not tuple cache enabled.

Tests:
Ran the tests in the build with tuple cache enabled.

Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
---
M bin/run-all-tests.sh
M tests/common/environ.py
M tests/common/skip.py
A tests/query_test/test_tuple_cache_tpc_queries.py
M tests/util/test_file_parser.py
5 files changed, 136 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/21628/4
-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 07:30:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 2:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py
File tests/query_test/test_tuple_cache_tpc_queries.py:

http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@20
PS2, Line 20: from builtins import range
flake8: F401 'builtins.range' imported but unused


http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@21
PS2, Line 21: import os
flake8: F401 'os' imported but unused


http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@39
PS2, Line 39: @SkipIf.not_tuple_cache
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@51
PS2, Line 51: a
flake8: W504 line break after binary operator


http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@59
PS2, Line 59: @SkipIf.not_tuple_cache
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/21628/2/tests/query_test/test_tuple_cache_tpc_queries.py@71
PS2, Line 71: a
flake8: W504 line break after binary operator



-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 06:39:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21628/3/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/21628/3/tests/common/environ.py@107
PS3, Line 107: IS_TUPLE_CACHE = os.getenv("TUPLE_CACHE_DIR", "") != ""
Enabling it requires both TUPLE_CACHE_DIR and TUPLE_CACHE_CAPACITY are set. run-all-tests.sh should guard against only setting one of them.



-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 17:59:11 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 4: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 15 Aug 2024 20:15:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21628/3/tests/common/environ.py
File tests/common/environ.py:

http://gerrit.cloudera.org:8080/#/c/21628/3/tests/common/environ.py@107
PS3, Line 107: IS_TUPLE_CACHE = (
> Enabling it requires both TUPLE_CACHE_DIR and TUPLE_CACHE_CAPACITY are set.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 21:22:42 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16607/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 21:48:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 6:

Thanks folks for reviewing.


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 14:16:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16604/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 2
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 07:04:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................

IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Added testcases to run TPC-H and TPC-DS queries twice with tuple
caching to verify that Impala won't crash and ensure the
correctness of the results.

Testcases allows mt_dop to be 0 or 4.

Also, added the environment varibles of tuple cache to
run-all-tests.sh and added skipif to test_tuple_cache_tpc_queries.py
to skip if not tuple cache enabled.

Tests:
Ran the tests in the build with tuple cache enabled.

Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Reviewed-on: http://gerrit.cloudera.org:8080/21628
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
M tests/common/environ.py
M tests/common/skip.py
A tests/query_test/test_tuple_cache_tpc_queries.py
M tests/util/test_file_parser.py
5 files changed, 136 insertions(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 6
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 02:32:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10868/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 5
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 16 Aug 2024 02:32:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16606/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 01 Aug 2024 14:43:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Posted by "Yida Wu (Code Review)" <ge...@cloudera.org>.
Yida Wu has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21628 )

Change subject: IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching
......................................................................

IMPALA-12907: Add testcases for TPC-H/TPC-DS queries with tuple caching

Added testcases to run TPC-H and TPC-DS queries twice with tuple
caching to verify that Impala won't crash and ensure the
correctness of the results.

Testcases allows mt_dop to be 0 or 4.

Also, added the environment varibles of tuple cache to
run-all-tests.sh and added skipif to test_tuple_cache_tpc_queries.py
to skip if not tuple cache enabled.

Tests:
Ran the tests in the build with tuple cache enabled.

Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
---
M bin/run-all-tests.sh
M tests/common/environ.py
M tests/common/skip.py
A tests/query_test/test_tuple_cache_tpc_queries.py
M tests/util/test_file_parser.py
5 files changed, 133 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/28/21628/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21628
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I967372744d8dda25cbe372aefec04faec5a76847
Gerrit-Change-Number: 21628
Gerrit-PatchSet: 3
Gerrit-Owner: Yida Wu <wy...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kd...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>