Re: [PR] Fix cron description treating "?" as a day-of-month/day-of-week conflict [airflow]

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #72292:
URL: https://github.com/apache/airflow/pull/72292#discussion_r3954431839


##########
airflow-core/tests/unit/timetables/test_cron_mixin.py:
##########
@@ -39,3 +41,20 @@ def test_dom_and_dow_conflict():
     assert "(or)" in desc
     assert "Every minute, on day 1 of the month" in desc
     assert "Every minute, only on Monday" in desc
+
+
+@pytest.mark.parametrize(
+    ("expression", "equivalent"),
+    [
+        pytest.param("0 0 ? * MON", "0 0 * * MON", id="question-mark-day-of-month"),
+        pytest.param("0 0 1 * ?", "0 0 1 * *", id="question-mark-day-of-week"),
+        pytest.param("0 0 ? * ?", "0 0 * * *", id="question-mark-both"),
+    ],
+)
+def test_question_mark_is_not_a_dom_dow_conflict(expression, equivalent):
+    # croniter expands "?" to "*", so it must describe the same as the "*" form
+    # instead of being reported as a day-of-month/day-of-week conflict.

Review Comment:
   This comment is not needed. It’s already present in the implementation; duplicating can potentially cause drift.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org