You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/16 22:50:24 UTC
[GitHub] [airflow] potiuk opened a new pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
potiuk opened a new pull request #13118:
URL: https://github.com/apache/airflow/pull/13118
Previously we skipped building 2.7 and 3.5 for master branch but
now we have also v2-0-test, so it is better to skip the
versions when branch is != v1-10-test (this is the only
DEFAULT_BRANCH - even in v1-10-stable builds v1-10-test is used
as DEFAULT_BRANCH is v1-10-test.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13118:
URL: https://github.com/apache/airflow/pull/13118#issuecomment-747091276
I was about to ask how the 2nd commit is relevant, but seems you revoked it? @potiuk
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13118:
URL: https://github.com/apache/airflow/pull/13118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13118:
URL: https://github.com/apache/airflow/pull/13118#issuecomment-747092446
Just wanted to be sure, unfiortunately the only way to test those changes is to push them as master in your own fork :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13118:
URL: https://github.com/apache/airflow/pull/13118#issuecomment-747092446
Just wanted to be sure, unfiortunately the only way to test those changes in 'workflow_run' is to push them as master in your own fork :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13118:
URL: https://github.com/apache/airflow/pull/13118#issuecomment-747092098
> I was about to ask how the 2nd commit is relevant, but seems you revoked it? @potiuk
Yeah. I was testing the v2--0-test branch on my fork and pushed it here accidentally.
You can see it here happilly skipping 2.7 and 3.5 when DEFAULT_BRANCH = v2-0-test :)
https://github.com/potiuk/airflow/actions/runs/426809582
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] XD-DENG commented on pull request #13118: For v2 target branches python 2.7 and 3.5 images are skipped
Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #13118:
URL: https://github.com/apache/airflow/pull/13118#issuecomment-747092900
Definitely good to be more sure ;-) Thanks for identifying and fixing this !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org