You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/08 06:51:41 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new pull request, #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
SbloodyS opened a new pull request, #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Fix #11314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #11345: [Doc] Add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207757757
> > there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
>
> I think we might have some doc checks in our `pre-commit hook` #11347 🤔
I haven't used this new feature yet. 🤣 Can we add this to the docs too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#discussion_r940055326
##########
README.md:
##########
@@ -98,11 +98,11 @@ You are very welcome to communicate with the developers and users of Dolphin Sch
### Contributor over time
-[](https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/dolphinscheduler)
+[]
Review Comment:
Maybe we should totally delete it, WDYT?
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207746153
there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207786444
> > there is a deadlink found, could you please also fix the dead link in this PR, it is related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
>
> I think we might have some doc checks in our `pre-commit hook` #11347 🤔
It is not related to our CI like github action or pre-hook, this dead link because we separate our docs into multiple repos, but they have to connect to each other. In this case, we have to use the whole URL in our document, but when we change the place of source docs(PR1), the link will be changed, and a dead link error throw.
The reason why we can pass CI in PR1 is that before the PR1 merged, the whole URL link still work, but it become deadlink when PR1 is be merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207754833
> there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
I think we might have some doc checks in our `pre-commit hook` https://github.com/apache/dolphinscheduler/issues/11347 :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207992376
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11345)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL) [2099 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_coverage&view=list) [37.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207759846
> > > there is a deadlink found, could you please also fix the dead link in this PR, it related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
> >
> >
> > I think we might have some doc checks in our `pre-commit hook` #11347 🤔
>
> I haven't used this new feature yet. 🤣 Can we add this to the docs too?
We have already had it in our docs. But later this week I will find a way to install the hook automatically for our developers in case they miss it in docs : ) https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/development-environment-setup.md#code-style
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207993358
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=11345)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG) [21 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY) [9 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT) [37 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL) [2099 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=11345&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_coverage&view=list) [37.9% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_duplicated_lines_density&view=list) [2.4% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=11345&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#issuecomment-1207788030
> > > there is a deadlink found, could you please also fix the dead link in this PR, it is related to the doc migration PR #11313 . You should change `/development/` to `docs/contribute`
> >
> >
> > I think we might have some doc checks in our `pre-commit hook` #11347 🤔
>
> It is not related to our CI like github action or pre-hook, this dead link because we separate our docs into multiple repos, but they have to connect to each other. In this case, we have to use the whole URL in our document, but when we change the place of source docs(PR1), the link will be changed, and a dead link error throw. The reason why we can pass CI in PR1 is that before the PR1 merged, the whole URL link still work, but it become deadlink when PR1 is be merged
Got it, thx @zhongjiajie for the explanations!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #11345: [Fix-11314] [Doc] add tools/libs to the init database steps
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #11345:
URL: https://github.com/apache/dolphinscheduler/pull/11345#discussion_r940057511
##########
README.md:
##########
@@ -98,11 +98,11 @@ You are very welcome to communicate with the developers and users of Dolphin Sch
### Contributor over time
-[](https://www.apiseven.com/en/contributor-graph?chart=contributorOverTime&repo=apache/dolphinscheduler)
+[]
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org