[GitHub] [spark] huaxingao commented on a diff in pull request #37031: [SPARK-39639][SQL] Fix possible null pointer in MySQLDialect listIndexes

[GitBox <gi...@apache.org>]

huaxingao commented on code in PR #37031:
URL: https://github.com/apache/spark/pull/37031#discussion_r912430337


##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -217,7 +219,7 @@ private case object MySQLDialect extends JdbcDialect with SQLConfHelper {
             // The only property we are building here is `COMMENT` because it's the only one
             // we can get from `SHOW INDEXES`.
             val properties = new util.Properties();
-            if (indexComment.nonEmpty) properties.put("COMMENT", indexComment)

Review Comment:
   Seems to me if `Index_comment` is not set, MySQL defaults it to empty String?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org