You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/27 02:50:27 UTC

[GitHub] srochel opened a new pull request #8825: Update install-mxnet-osx-python.sh

srochel opened a new pull request #8825: Update install-mxnet-osx-python.sh
URL: https://github.com/apache/incubator-mxnet/pull/8825
 
 
   Fixed handling of MXNET_TAG. If not set latest from master will be cloned to local directory. If a tag is specified, that tag will be used to clone the repository.
   
   Tested with 
   MXNET_TAG="1.0.0.rc0" and MXNET_TAG not set in local environment
   
   ## Description ##
   Fixed handling of MXNET_TAG. If not set latest from master will be cloned to local directory. If a tag is specified, that tag will be used to clone the repository.
   
   ## Checklist ##
   ### Essentials ###
   - [y] Passed code style checking (`make lint`)
   - [y] Changes are complete (i.e. I finished coding on this PR)
   - [n] All changes have test coverage
   - [n] For user-facing API changes, API doc string has been updated. For new C++ functions in header files, their functionalities and arguments are well-documented. 
   - [n] To my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [n] Feature1, tests, (and when applicable, API doc)
   - [n] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - change does not include check if tag in repo exists, can be further enhancement.
   I will work with Aaron to update documentation.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services