[GitHub] [incubator-superset] rusackas commented on a change in pull request #11525: fix: extended droppable area on the top of dashboards

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #11525:
URL: https://github.com/apache/incubator-superset/pull/11525#discussion_r517519769



##########
File path: superset-frontend/src/dashboard/stylesheets/dnd.less
##########
@@ -123,7 +129,12 @@
   }
 
   & > .empty-droptarget:first-child {
-    height: 24px;
+    height: 48px;
     margin-top: -24px;
+    margin-bottom: -24px;
+  }
+
+  & > .empty-droptarget:only-child {
+    height: 80vh;

Review comment:
       This `vh` unit might not be accurate on viewports that are very tall or very short. The header area is not a flexible 20%, but some fixed height I believe. You might be better off with something like `height: calc(100vh - XXpx)`
   
   That said I'm LOVING this idea.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org