You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@samza.apache.org by Shanthoosh Venkataraman <sa...@gmail.com> on 2016/09/07 20:49:44 UTC

Review Request 51703: Enable passing of Configs and MetricsRegistry into Monitor objects.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51703/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

This patch aims at adding the following functionalities to Samza-Rest monitors.

* Schedule different monitors at different intervals of time.
* Define custom monitor configurations and pass config along to the monitor objects.
* Default implementation of building monitor configuration from properties file.


Diffs
-----

  samza-rest/src/main/java/org/apache/samza/monitor/DefaultMonitorFactory.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/monitor/MonitorFactory.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/monitor/SamzaMonitorService.java 2f4d9ddb76369c5e83d39152d492807dfb164981 
  samza-rest/src/main/java/org/apache/samza/monitor/SchedulingProvider.java aea1a9291e651660c798cabf59fcf0c0623bcbd0 
  samza-rest/src/main/java/org/apache/samza/monitor/config/MonitorConfig.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/monitor/config/MonitorConfigFactory.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/monitor/config/PropertiesMonitorConfigFactory.java PRE-CREATION 
  samza-rest/src/main/java/org/apache/samza/rest/SamzaRestConfig.java 6f5c10ac89523626c7f7e05558422daad2ccd4e8 
  samza-rest/src/test/java/org/apache/samza/monitor/TestMonitorService.java 1da343012b85f96f837e3cbf9a54ced3b29fede6 
  samza-rest/src/test/java/org/apache/samza/monitor/config/TestPropertiesMonitorConfigFactory.java PRE-CREATION 
  samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitor.java 8621db1b0e8ce3279cc8a5cb3a21bd137d442034 
  samza-rest/src/test/java/org/apache/samza/monitor/mock/DummyMonitorConfigFactory.java PRE-CREATION 
  samza-rest/src/test/java/org/apache/samza/monitor/mock/ExceptionThrowingMonitor.java c4f3f735f78d56f8bb3ef203a05e2bec92489767 
  samza-rest/src/test/resources/monitorconfig.properties PRE-CREATION 

Diff: https://reviews.apache.org/r/51703/diff/


Testing
-------

Unit tests are used to verify the intended functionality.


Thanks,

Shanthoosh Venkataraman