You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "xinyiZzz (via GitHub)" <gi...@apache.org> on 2023/08/21 20:52:51 UTC
[GitHub] [doris] xinyiZzz opened a new pull request, #23290: [enhancement](thirdparty) upgrade thirdparty libs
xinyiZzz opened a new pull request, #23290:
URL: https://github.com/apache/doris/pull/23290
## Proposed changes
protobuf 3.15.0 -> 21.11
glog 0.4.0 -> 0.6.0
lz4 1.9.3 -> 1.9.4
curl 7.79.0 -> 8.2.1
brpc 1.4.0 -> 1.6.0
zstd 1.5.2 -> 1.5.5
arrow 7.0.0 -> 13.0.0
abseil 20220623.1 -> 20230125.3
orc 1.7.2 -> 1.9.0
jemalloc for arrow 5.2.1 -> 5.3.0
xsimd 7.0.0 -> 13.0.0
opentelemetry-proto 0.19.0 -> 1.0.0
opentelemetry 1.8.3 -> 1.10.0
new:
c-ares -> 1.19.1
grpc -> 1.54.3
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "adonis0147 (via GitHub)" <gi...@apache.org>.
adonis0147 commented on code in PR #23290:
URL: https://github.com/apache/doris/pull/23290#discussion_r1302389090
##########
thirdparty/vars.sh:
##########
@@ -197,10 +198,10 @@ LEVELDB_SOURCE=leveldb-1.23
LEVELDB_MD5SUM="afbde776fb8760312009963f09a586c7"
# brpc
-BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.4.0.tar.gz"
-BRPC_NAME="brpc-1.4.0.tar.gz"
-BRPC_SOURCE="brpc-1.4.0"
-BRPC_MD5SUM="6af9d50822c33a3abc56a1ec0af0e0bc"
+BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.6.0.tar.gz"
+BRPC_NAME="1.6.0.tar.gz"
Review Comment:
```suggestion
BRPC_NAME="brpc-1.6.0.tar.gz"
```
##########
thirdparty/vars.sh:
##########
@@ -417,16 +431,16 @@ NLOHMANN_JSON_SOURCE=json-3.10.1
NLOHMANN_JSON_MD5SUM="7b369d567afc0dffdcf5800fd9abb836"
# opentelemetry-proto
-OPENTELEMETRY_PROTO_DOWNLOAD="https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/v0.19.0.tar.gz"
-OPENTELEMETRY_PROTO_NAME=opentelemetry-proto-0.19.0.tar.gz
-OPENTELEMETRY_PROTO_SOURCE=opentelemetry-proto-0.19.0
-OPENTELEMETRY_PROTO_MD5SUM="8a5fb1ba721341994a5e7cae8b38bcc6"
+OPENTELEMETRY_PROTO_DOWNLOAD="https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/v1.0.0.tar.gz"
+OPENTELEMETRY_PROTO_NAME=v1.0.0.tar.gz
Review Comment:
```suggestion
OPENTELEMETRY_PROTO_NAME="opentelemetry-proto-v1.0.0.tar.gz"
```
##########
thirdparty/vars.sh:
##########
@@ -398,11 +412,11 @@ BENCHMARK_SOURCE=benchmark-1.8.0
BENCHMARK_MD5SUM="8ddf8571d3f6198d37852bcbd964f817"
# xsimd
-# for arrow-7.0.0, if arrow upgrade, this version may also need to be changed
-XSIMD_DOWNLOAD="https://github.com/xtensor-stack/xsimd/archive/aeec9c872c8b475dedd7781336710f2dd2666cb2.tar.gz"
-XSIMD_NAME=xsimd-aeec9c872c8b475dedd7781336710f2dd2666cb2.tar.gz
-XSIMD_SOURCE=xsimd-aeec9c872c8b475dedd7781336710f2dd2666cb2
-XSIMD_MD5SUM="d024855f71c0a2837a6918c0f8f66245"
+# for arrow-13.0.0, if arrow upgrade, this version may also need to be changed
+XSIMD_DOWNLOAD="https://github.com/xtensor-stack/xsimd/archive/refs/tags/9.0.1.tar.gz"
+XSIMD_NAME="9.0.1.tar.gz"
Review Comment:
```suggestion
XSIMD_NAME="xsimd-9.0.1.tar.gz"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #23290:
URL: https://github.com/apache/doris/pull/23290#discussion_r1302461579
##########
thirdparty/vars.sh:
##########
@@ -197,10 +198,10 @@ LEVELDB_SOURCE=leveldb-1.23
LEVELDB_MD5SUM="afbde776fb8760312009963f09a586c7"
# brpc
-BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.4.0.tar.gz"
-BRPC_NAME="brpc-1.4.0.tar.gz"
-BRPC_SOURCE="brpc-1.4.0"
-BRPC_MD5SUM="6af9d50822c33a3abc56a1ec0af0e0bc"
+BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.6.0.tar.gz"
+BRPC_NAME="1.6.0.tar.gz"
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1687036534
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1688558660
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.7 seconds
stream load tsv: 537 seconds loaded 74807831229 Bytes, about 132 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162073019 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #23290:
URL: https://github.com/apache/doris/pull/23290#discussion_r1302461855
##########
thirdparty/vars.sh:
##########
@@ -417,16 +431,16 @@ NLOHMANN_JSON_SOURCE=json-3.10.1
NLOHMANN_JSON_MD5SUM="7b369d567afc0dffdcf5800fd9abb836"
# opentelemetry-proto
-OPENTELEMETRY_PROTO_DOWNLOAD="https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/v0.19.0.tar.gz"
-OPENTELEMETRY_PROTO_NAME=opentelemetry-proto-0.19.0.tar.gz
-OPENTELEMETRY_PROTO_SOURCE=opentelemetry-proto-0.19.0
-OPENTELEMETRY_PROTO_MD5SUM="8a5fb1ba721341994a5e7cae8b38bcc6"
+OPENTELEMETRY_PROTO_DOWNLOAD="https://github.com/open-telemetry/opentelemetry-proto/archive/refs/tags/v1.0.0.tar.gz"
+OPENTELEMETRY_PROTO_NAME=v1.0.0.tar.gz
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1689274756
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 44.97 seconds
stream load tsv: 554 seconds loaded 74807831229 Bytes, about 128 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.4 seconds inserted 10000000 Rows, about 340K ops/s
storage size: 17162085456 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1688505657
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1687615485
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1687657545
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 48.71 seconds
stream load tsv: 553 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 31 seconds loaded 861443392 Bytes, about 26 MB/s
insert into select: 29.2 seconds inserted 10000000 Rows, about 342K ops/s
storage size: 17162299264 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morningman merged pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "morningman (via GitHub)" <gi...@apache.org>.
morningman merged PR #23290:
URL: https://github.com/apache/doris/pull/23290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1687029115
#### `sh-checker report`
To get the full details, please check in the [job]("https://github.com/apache/doris/actions/runs/5931344934") output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In thirdparty/build-thirdparty.sh line 432:
-DCMAKE_PREFIX_PATH=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 439:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} ../..
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" ../..
In thirdparty/build-thirdparty.sh line 935:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} ..
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" ..
In thirdparty/build-thirdparty.sh line 951:
-DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 953:
-Dc-ares_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-Dc-ares_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 955:
-Dabsl_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-Dabsl_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 957:
-DProtobuf_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DProtobuf_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 959:
-Dre2_DIR:STRING=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-Dre2_DIR:STRING="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 961:
-DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DOPENSSL_ROOT_DIR="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 963:
-DZLIB_ROOT=${TP_INSTALL_DIR} \
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
-DZLIB_ROOT="${TP_INSTALL_DIR}" \
In thirdparty/build-thirdparty.sh line 971:
sed -i 's/find_dependency/find_package/g' ${TP_INSTALL_DIR}/lib64/cmake/grpc/gRPCConfig.cmake
^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean:
sed -i 's/find_dependency/find_package/g' "${TP_INSTALL_DIR}"/lib64/cmake/grpc/gRPCConfig.cmake
For more information:
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- thirdparty/build-thirdparty.sh.orig
+++ thirdparty/build-thirdparty.sh
@@ -427,7 +427,7 @@
cd cmake/build
CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \
- LDFLAGS="${ldflags}" \
+ LDFLAGS="${ldflags}" \
"${CMAKE_CMD}" -DCMAKE_BUILD_TYPE=Release \
-DCMAKE_PREFIX_PATH=${TP_INSTALL_DIR} \
-Dprotobuf_USE_EXTERNAL_GTEST=ON \
@@ -946,23 +946,23 @@
cd cmake/build
cmake -DgRPC_INSTALL=ON \
- -DgRPC_BUILD_TESTS=OFF \
- -DCMAKE_BUILD_TYPE=Release \
- -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
- -DgRPC_CARES_PROVIDER=package \
- -Dc-ares_DIR=${TP_INSTALL_DIR} \
- -DgRPC_ABSL_PROVIDER=package \
- -Dabsl_DIR=${TP_INSTALL_DIR} \
- -DgRPC_PROTOBUF_PROVIDER=package \
- -DProtobuf_DIR=${TP_INSTALL_DIR} \
- -DgRPC_RE2_PROVIDER=package \
- -Dre2_DIR:STRING=${TP_INSTALL_DIR} \
- -DgRPC_SSL_PROVIDER=package \
- -DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
- -DgRPC_ZLIB_PROVIDER=package \
- -DZLIB_ROOT=${TP_INSTALL_DIR} \
- -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
- ../..
+ -DgRPC_BUILD_TESTS=OFF \
+ -DCMAKE_BUILD_TYPE=Release \
+ -DCMAKE_INSTALL_PREFIX=${TP_INSTALL_DIR} \
+ -DgRPC_CARES_PROVIDER=package \
+ -Dc-ares_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_ABSL_PROVIDER=package \
+ -Dabsl_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_PROTOBUF_PROVIDER=package \
+ -DProtobuf_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_RE2_PROVIDER=package \
+ -Dre2_DIR:STRING=${TP_INSTALL_DIR} \
+ -DgRPC_SSL_PROVIDER=package \
+ -DOPENSSL_ROOT_DIR=${TP_INSTALL_DIR} \
+ -DgRPC_ZLIB_PROVIDER=package \
+ -DZLIB_ROOT=${TP_INSTALL_DIR} \
+ -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
+ ../..
make -j "${PARALLEL}"
make install
@@ -1579,8 +1579,8 @@
cd "${BUILD_DIR}"
CXXFLAGS="-O2 -I${TP_INCLUDE_DIR}" \
- LDFLAGS="-L${TP_LIB_DIR}" \
- "${CMAKE_CMD}" -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
+ LDFLAGS="-L${TP_LIB_DIR}" \
+ "${CMAKE_CMD}" -G "${GENERATOR}" -DCMAKE_INSTALL_PREFIX="${TP_INSTALL_DIR}" \
-DCMAKE_PREFIX_PATH="${TP_INSTALL_DIR}" \
-DBUILD_TESTING=OFF \
-DWITH_OTLP_GRPC=ON \
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1689332741
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1689255941
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1689332794
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on a diff in pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on code in PR #23290:
URL: https://github.com/apache/doris/pull/23290#discussion_r1302461745
##########
thirdparty/vars.sh:
##########
@@ -398,11 +412,11 @@ BENCHMARK_SOURCE=benchmark-1.8.0
BENCHMARK_MD5SUM="8ddf8571d3f6198d37852bcbd964f817"
# xsimd
-# for arrow-7.0.0, if arrow upgrade, this version may also need to be changed
-XSIMD_DOWNLOAD="https://github.com/xtensor-stack/xsimd/archive/aeec9c872c8b475dedd7781336710f2dd2666cb2.tar.gz"
-XSIMD_NAME=xsimd-aeec9c872c8b475dedd7781336710f2dd2666cb2.tar.gz
-XSIMD_SOURCE=xsimd-aeec9c872c8b475dedd7781336710f2dd2666cb2
-XSIMD_MD5SUM="d024855f71c0a2837a6918c0f8f66245"
+# for arrow-13.0.0, if arrow upgrade, this version may also need to be changed
+XSIMD_DOWNLOAD="https://github.com/xtensor-stack/xsimd/archive/refs/tags/9.0.1.tar.gz"
+XSIMD_NAME="9.0.1.tar.gz"
Review Comment:
fixed
##########
thirdparty/vars.sh:
##########
@@ -197,10 +198,10 @@ LEVELDB_SOURCE=leveldb-1.23
LEVELDB_MD5SUM="afbde776fb8760312009963f09a586c7"
# brpc
-BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.4.0.tar.gz"
-BRPC_NAME="brpc-1.4.0.tar.gz"
-BRPC_SOURCE="brpc-1.4.0"
-BRPC_MD5SUM="6af9d50822c33a3abc56a1ec0af0e0bc"
+BRPC_DOWNLOAD="https://github.com/apache/brpc/archive/refs/tags/1.6.0.tar.gz"
+BRPC_NAME="1.6.0.tar.gz"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] xinyiZzz commented on pull request #23290: [enhancement](thirdparty) upgrade thirdparty libs
Posted by "xinyiZzz (via GitHub)" <gi...@apache.org>.
xinyiZzz commented on PR #23290:
URL: https://github.com/apache/doris/pull/23290#issuecomment-1689253586
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org