You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by aa...@apache.org on 2019/02/12 18:05:37 UTC
[incubator-pinot] branch master updated: [TE] frontend -
aarouncsd/add debug global flag (#3818)
This is an automated email from the ASF dual-hosted git repository.
aaronucsd pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 4039e57 [TE] frontend - aarouncsd/add debug global flag (#3818)
4039e57 is described below
commit 4039e57f4bcecd04e0320a213b681f903d9f5772
Author: Long Huynh <lo...@linkedin.com>
AuthorDate: Tue Feb 12 10:05:31 2019 -0800
[TE] frontend - aarouncsd/add debug global flag (#3818)
1. global debug flag param for application
2. use debug param flag for show/hide yaml toggle
```
?debug=show
```
---
.../app/pods/application/controller.js | 4 ++-
.../app/pods/application/route.js | 11 ++++++-
.../app/pods/self-serve/create-alert/controller.js | 9 ++++--
.../app/pods/self-serve/create-alert/route.js | 6 +++-
.../app/pods/self-serve/create-alert/template.hbs | 36 ++++++++++++----------
5 files changed, 43 insertions(+), 23 deletions(-)
diff --git a/thirdeye/thirdeye-frontend/app/pods/application/controller.js b/thirdeye/thirdeye-frontend/app/pods/application/controller.js
index a22ee4e..31f298b 100644
--- a/thirdeye/thirdeye-frontend/app/pods/application/controller.js
+++ b/thirdeye/thirdeye-frontend/app/pods/application/controller.js
@@ -4,13 +4,15 @@
* @exports application
*/
import { inject as service } from '@ember/service';
-
+import { observer, get, set } from '@ember/object';
import { alias } from '@ember/object/computed';
import Controller from '@ember/controller';
export default Controller.extend({
showNavbar: alias('model'),
session: service(),
+ queryParams: ['debug'],
+ debug: null,
/**
* Global navbar items
diff --git a/thirdeye/thirdeye-frontend/app/pods/application/route.js b/thirdeye/thirdeye-frontend/app/pods/application/route.js
index 210f687..f6badf1 100644
--- a/thirdeye/thirdeye-frontend/app/pods/application/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/application/route.js
@@ -5,11 +5,20 @@ import fetch from 'fetch';
import { checkStatus } from 'thirdeye-frontend/utils/utils';
import config from 'thirdeye-frontend/config/environment';
+// Prevent a full transition and pushState
+const queryParamsConfig = {
+ refreshModel: false,
+ replace: false
+};
+
export default Route.extend(ApplicationRouteMixin, {
moment: service(),
session: service(),
notifications: service('toast'),
-
+ queryParams: {
+ debug: queryParamsConfig,
+ },
+
beforeModel() {
// calling this._super to trigger ember-simple-auth's hook
this._super(...arguments);
diff --git a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/controller.js b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/controller.js
index df503e9..7c62ec4 100644
--- a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/controller.js
+++ b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/controller.js
@@ -31,6 +31,7 @@ import {
import config from 'thirdeye-frontend/config/environment';
export default Controller.extend({
+ notifications: service('toast'),
/**
* Initialized alert creation page settings
@@ -69,7 +70,6 @@ export default Controller.extend({
snippet: ''
}],
metricHelpMailto: `mailto:${config.email}?subject=Metric Onboarding Request (non-additive UMP or derived)`,
- isDevEnv: config.environment === 'development',
/**
* Component property initial settings
@@ -115,8 +115,6 @@ export default Controller.extend({
}
},
- notifications: service('toast'),
-
/**
* Severity display options (power-select) and values
* @type {Object}
@@ -206,6 +204,11 @@ export default Controller.extend({
allAlertsConfigGroups: reads('model.allConfigGroups'),
/**
+ * The debug flag
+ */
+ debug: reads('model.debug'),
+
+ /**
* Handler for search by function name - using ember concurrency (task)
* @method searchMetricsList
* @param {metric} String - portion of metric name used in typeahead
diff --git a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/route.js b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/route.js
index 480809b..d31a0f5 100644
--- a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/route.js
+++ b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/route.js
@@ -14,20 +14,24 @@ import {
} from 'thirdeye-frontend/utils/api/self-serve';
import { postProps, checkStatus } from 'thirdeye-frontend/utils/utils';
import { inject as service } from '@ember/service';
+import { get } from '@ember/object';
let onboardStartTime = {};
export default Route.extend({
session: service(),
+
/**
* Model hook for the create alert route.
* @method model
* @return {Object}
*/
model(params, transition) {
+ const debug = transition.state.queryParams.debug || '';
return RSVP.hash({
allConfigGroups: fetch(selfServeApiCommon.allConfigGroups).then(checkStatus),
- allAppNames: fetch(selfServeApiCommon.allApplications).then(checkStatus)
+ allAppNames: fetch(selfServeApiCommon.allApplications).then(checkStatus),
+ debug
});
},
diff --git a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/template.hbs b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/template.hbs
index 9e41d86..228ae0a 100644
--- a/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/template.hbs
+++ b/thirdeye/thirdeye-frontend/app/pods/self-serve/create-alert/template.hbs
@@ -1,21 +1,23 @@
<h1 class="te-title">Create Alert
- {{#x-toggle
- value=isForm
- classNames="te-toggle te-toggle--form te-toggle--left report-toggle pull-right"
- theme="ios"
- id="label-toggle"
- showLabels=true
- name="activeToggle"
- onToggle=(action (mut isForm))
- as |toggle|}}
- {{#toggle.label value=isForm}}
- <span class="te-label te-label--flush">YAML</span>
- {{/toggle.label}}
- {{toggle.switch theme='ios' onLabel='diff on' offLabel='diff off'}}
- {{#toggle.label value=isForm}}
- <span class="te-label te-label--flush">Form</span>
- {{/toggle.label}}
- {{/x-toggle}}
+ {{#if (eq debug "show")}}
+ {{#x-toggle
+ value=isForm
+ classNames="te-toggle te-toggle--form te-toggle--left report-toggle pull-right"
+ theme="ios"
+ id="label-toggle"
+ showLabels=true
+ name="activeToggle"
+ onToggle=(action (mut isForm))
+ as |toggle|}}
+ {{#toggle.label value=isForm}}
+ <span class="te-label te-label--flush">YAML</span>
+ {{/toggle.label}}
+ {{toggle.switch theme='ios' onLabel='diff on' offLabel='diff off'}}
+ {{#toggle.label value=isForm}}
+ <span class="te-label te-label--flush">Form</span>
+ {{/toggle.label}}
+ {{/x-toggle}}
+ {{/if}}
</h1>
<main class="alert-create card-container card-container--padded te-form">
{{#if isForm}}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org