[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9571: [charts] feat: add statsd to charts api

[GitBox <gi...@apache.org>]

dpgaspar commented on a change in pull request #9571: [charts] feat: add statsd to charts api
URL: https://github.com/apache/incubator-superset/pull/9571#discussion_r410722493
 
 

 ##########
 File path: tests/charts/api_tests.py
 ##########
 @@ -631,25 +631,25 @@ def test_get_charts_page(self):
 
         arguments = {"page_size": 10, "page": 3}
         uri = f"api/v1/chart/?q={prison.dumps(arguments)}"
-        rv = self.client.get(uri)
+        rv = self.get_assert_metric(uri, "get_list")
         self.assertEqual(rv.status_code, 200)
         data = json.loads(rv.data.decode("utf-8"))
         self.assertEqual(len(data["result"]), 3)
 
     def test_get_charts_no_data_access(self):
         """
-            Chart API: Test get charts no data access
+        Chart API: Test get charts no data access
         """
         self.login(username="gamma")
         uri = f"api/v1/chart/"
-        rv = self.client.get(uri)
+        rv = self.get_assert_metric(uri, "get_list")
         self.assertEqual(rv.status_code, 200)
         data = json.loads(rv.data.decode("utf-8"))
         self.assertEqual(data["count"], 0)
 
     def test_chart_data(self):
         """
-            Query API: Test chart data query
+        Query API: Test chart data query
 
 Review comment:
   missing the statsd asserts wrapper

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org