You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/01/11 19:33:32 UTC
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9007
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
IMPALA-6363: avoid cscope build races
Use the -ignore_readdir_race flag for find so that find doesn't fail if
a directory disappears under it. From what I could tell the flag has
been in GNU find for a long time and is also available in other OS
flavours like BSD and OS X.
Make the step depend on gen-deps so that it can index thrift, protobuf,
etc, output.
Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
---
M CMakeLists.txt
M bin/gen-cscope.sh
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/9007/1
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
IMPALA-6363: avoid cscope build races
Use the -ignore_readdir_race flag for find so that find doesn't fail if
a directory disappears under it. From what I could tell the flag has
been in GNU find for a long time and is also available in other OS
flavours like BSD and OS X.
Make the step depend on gen-deps so that it can index thrift, protobuf,
etc, output.
Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Reviewed-on: http://gerrit.cloudera.org:8080/9007
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M CMakeLists.txt
M bin/gen-cscope.sh
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1717/
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 19:51:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1717/
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 23:25:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1722/
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 23:45:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2:
Hit a flaky test - filed IMPALA-6394
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 23:46:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Sat, 13 Jan 2018 03:24:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 1: Code-Review+1
It seems like this couldn't hurt even if IMPALA-6363 does not happen much. I had the luxury of checking a CentOS 5 host, and the -ignore_readdir_race flag does exist there.
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 19:41:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 19:32:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 2: Code-Review+2
carry
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jan 2018 19:50:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6363: avoid cscope build races
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9007 )
Change subject: IMPALA-6363: avoid cscope build races
......................................................................
Patch Set 1:
Yeah, I figure we could go ahead with this and see if the problem stops reproducing.
--
To view, visit http://gerrit.cloudera.org:8080/9007
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I22bdb7c64036cb88a8a10907af35c5e3a55a9195
Gerrit-Change-Number: 9007
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jan 2018 19:46:46 +0000
Gerrit-HasComments: No