You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/24 09:18:10 UTC

[GitHub] HeartSaVioR commented on issue #23634: [SPARK-26187][SQL] Left/right outer join should not return outer nulls for already matched rows

HeartSaVioR commented on issue #23634: [SPARK-26187][SQL] Left/right outer join should not return outer nulls for already matched rows
URL: https://github.com/apache/spark/pull/23634#issuecomment-457124046
 
 
   Code cleaning needs to be done. I would like to get it reviewed regardless of code cleaning since this looks like correctness issue, and I would like to know earlier that the approach I've taken is acceptable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org