You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@knox.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2019/11/12 21:20:00 UTC
[jira] [Commented] (KNOX-2122) Code cleanup from static code
analysis
[ https://issues.apache.org/jira/browse/KNOX-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16972791#comment-16972791 ]
ASF subversion and git services commented on KNOX-2122:
-------------------------------------------------------
Commit 2b6cee2d9081628348e0925a9e7e7b596292eee3 in knox's branch refs/heads/master from Kevin Risden
[ https://gitbox.apache.org/repos/asf?p=knox.git;h=2b6cee2 ]
KNOX-2122 - Code cleanup from static code analysis (#191)
* Diamond operator
* Static method calls instead of on instances
* Remove null check before instanceof
* Use computeIfAbsent where possible
* Remove simple nested if statements
* Remove redundant cast
* Use entrySet for iteration of maps
Signed-off-by: Kevin Risden <kr...@apache.org>
> Code cleanup from static code analysis
> --------------------------------------
>
> Key: KNOX-2122
> URL: https://issues.apache.org/jira/browse/KNOX-2122
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Priority: Minor
> Fix For: 1.4.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> * Diamond operator
> * Static method calls instead of on instances
> * Remove null check before instanceof
> * Use computeIfAbsent where possible
> * Remove simple nested if statements
> * Remove redundant cast
> * Use entrySet for iteration of maps
--
This message was sent by Atlassian Jira
(v8.3.4#803005)