You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tianyi Wang (Code Review)" <ge...@cloudera.org> on 2018/06/07 18:54:35 UTC
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Tianyi Wang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10640
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
IMPALA-3040: Print logs around removeDirective()
I observed that some caching directives on partitions doesn't get
removed. HDFS would throw an exception if removeDirective operation
fails on its side, so I suspect that removeDirective isn't called by
catalogd. This patch prints logs around removeDirective if it's skipped.
Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
---
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
1 file changed, 23 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/10640/1
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 1
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Posted by "Tianyi Wang (Code Review)" <ge...@cloudera.org>.
Tianyi Wang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/10640 )
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
IMPALA-3040: Print logs around removeDirective()
I observed that some caching directives on partitions don't get
removed. HDFS would throw an exception if removeDirective() operation
fails on its side, so I suspect that removeDirective() isn't called by
catalogd. This patch prints logs around removeDirective() if it's
skipped.
Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
---
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
1 file changed, 22 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/40/10640/2
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 )
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
Patch Set 2: Code-Review+2
Makes sense. Let's merge this so we debug this issue.
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 19:05:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 )
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/2619/
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 19:10:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10640 )
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 2
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 22:36:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3040: Print logs around removeDirective()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10640 )
Change subject: IMPALA-3040: Print logs around removeDirective()
......................................................................
IMPALA-3040: Print logs around removeDirective()
I observed that some caching directives on partitions don't get
removed. HDFS would throw an exception if removeDirective() operation
fails on its side, so I suspect that removeDirective() isn't called by
catalogd. This patch prints logs around removeDirective() if it's
skipped.
Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Reviewed-on: http://gerrit.cloudera.org:8080/10640
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/util/HdfsCachingUtil.java
1 file changed, 22 insertions(+), 4 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9d9f6eb1951c77e095d5029e8bbdc67e9b39b814
Gerrit-Change-Number: 10640
Gerrit-PatchSet: 3
Gerrit-Owner: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>