You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/10/19 09:48:15 UTC

[GitHub] [dolphinscheduler] danielfree commented on pull request #12358: [Fix-12356][k8s] fix the null exception when submitting k8s task plugin

danielfree commented on PR #12358:
URL: https://github.com/apache/dolphinscheduler/pull/12358#issuecomment-1283728295

   hi @caishunfeng @rickchengx  i also found out this bug and fixed it, need to point out that this pr's solution won't work because `cluster.getConfig();` result is not a valid kubeconfig yaml(it's the json string stored in that table), you have to use this:  `ClusterConfUtils.getK8sConfig(cluster.getConfig());` 
   
   the current change only succeeds to submit the task, but the kubeconfig is not valid so the ds-worker won't submit the job successfully.
   
   @rickchengx maybe you can submit a new pr for the change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org