[jira] [Work logged] (HIVE-26293) Migrate remaining exclusive DDL operations to EXCL_WRITE lock & bug fixes

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-26293?focusedWorklogId=778944&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-778944 ]

ASF GitHub Bot logged work on HIVE-26293:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 07/Jun/22 09:25
            Start Date: 07/Jun/22 09:25
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3103:
URL: https://github.com/apache/hive/pull/3103#discussion_r890988670


##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/misc/msck/MsckAnalyzer.java:
##########
@@ -87,7 +87,8 @@ public void analyzeInternal(ASTNode root) throws SemanticException {
     }
 
     if (repair && AcidUtils.isTransactionalTable(table)) {
-      outputs.add(new WriteEntity(table, WriteType.DDL_EXCLUSIVE));
+      outputs.add(new WriteEntity(table, AcidUtils.isLocklessReadsEnabled(table, conf) ? 

Review Comment:
   Maybe a little late, maybe it is not viable, but I feel that we spread this checks all around the code now. Would it be possible to translate the `WriteType` to the lock type in one place instead?
   
   Maybe in a different PR later?





Issue Time Tracking
-------------------

            Worklog Id:     (was: 778944)
    Remaining Estimate: 0h
            Time Spent: 10m

> Migrate remaining exclusive DDL operations to EXCL_WRITE lock & bug fixes
> -------------------------------------------------------------------------
>
>                 Key: HIVE-26293
>                 URL: https://issues.apache.org/jira/browse/HIVE-26293
>             Project: Hive
>          Issue Type: Task
>            Reporter: Denys Kuzmenko
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)