You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/02/10 11:55:59 UTC
[PR] Improve build script and instruction [spark-website]
pan3793 opened a new pull request, #675:
URL: https://github.com/apache/spark-website/pull/675
<!-- *Make sure that you generate site HTML with `bundle exec jekyll build`, and include the changes to the HTML in your pull request. See README.md for more information.* -->
- Grant `x` permission to `.dev/*.sh` scripts so we can execute directly instead of calling `sh foo.sh`
- Remove unused env var `SPARK_WEBSITE_PATH` in building instruction, it exists neither in this repo nor the main repo
- Correctly set `JAVA_HOME` for both x86_64 and arm platforms (is JAVA_HOME really required? I'm not sure)
- Fix issues when the host machine has the same UID and GID as the container. For example, my host runs Ubuntu 24.04, the default UID is 1000, and the docs image also uses Ubuntu 24.04 and has the user `ubuntu` with the same UID 1000.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Improve build script and instruction [spark-website]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #675:
URL: https://github.com/apache/spark-website/pull/675#discussion_r2788534038
##########
README.md:
##########
@@ -18,7 +18,7 @@ docker build \
Once the image is built, navigate to the `spark-website` root directory, run the script which processes
the Markdown files in the Docker container.
```
-SPARK_WEBSITE_PATH="/path/to/spark-website" sh .dev/build-docs.sh
+.dev/build-docs.sh
Review Comment:
should this lead to a html file change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Improve build script and instruction [spark-website]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan merged PR #675:
URL: https://github.com/apache/spark-website/pull/675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org
Re: [PR] Improve build script and instruction [spark-website]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #675:
URL: https://github.com/apache/spark-website/pull/675#discussion_r2789081495
##########
README.md:
##########
@@ -18,7 +18,7 @@ docker build \
Once the image is built, navigate to the `spark-website` root directory, run the script which processes
the Markdown files in the Docker container.
```
-SPARK_WEBSITE_PATH="/path/to/spark-website" sh .dev/build-docs.sh
+.dev/build-docs.sh
Review Comment:
it's `README.md`, html does not have a counterpart
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org