[GitHub] [ignite-3] tkalkirill commented on a diff in pull request #1901: IGNITE-19220 Prohibit marking NetworkMessage with Marshallable

["tkalkirill (via GitHub)" <gi...@apache.org>]

tkalkirill commented on code in PR #1901:
URL: https://github.com/apache/ignite-3/pull/1901#discussion_r1159284457


##########
modules/network-annotation-processor/src/main/java/org/apache/ignite/internal/network/processor/messages/MessageImplGenerator.java:
##########
@@ -111,6 +113,14 @@ public TypeSpec generateMessageImpl(MessageClass message, TypeSpec builderInterf
                     .addModifiers(Modifier.PRIVATE);
 
             boolean isMarshallable = getter.getAnnotation(Marshallable.class) != null;
+            boolean isMessage = typeUtils.isSubType(getterType, NetworkMessage.class);

Review Comment:
   ```suggestion
               boolean isNetworkMessage = typeUtils.isSubType(getterType, NetworkMessage.class);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org