You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/11 09:02:12 UTC
[GitHub] [hadoop-ozone] danidelvalle opened a new pull request #809:
HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
danidelvalle opened a new pull request #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/809
## What changes were proposed in this pull request?
Handle InterruptedException in ratis related files:
* OzoneManagerDoubleBuffer: https://sonarcloud.io/project/issues?id=hadoop-ozone&issues=AW5md-VxKcVY8lQ4Zrtu&open=AW5md-VxKcVY8lQ4Zrtu
* ~~OzoneManagerRatisClient~~: removed in [HDDS-1991](https://issues.apache.org/jira/browse/HDDS-1991)
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2576
## How was this patch tested?
Compiles successfully without any errors in local.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] danidelvalle commented on issue #809: HDDS-2576.
Handle InterruptedException in OzoneManagerDoubleBuffer
Posted by GitBox <gi...@apache.org>.
danidelvalle commented on issue #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/809#issuecomment-616078831
@elek I agree this is probably a false possitive and marking the thread as interrupted is quite unnecessary. However, I guess it would worth it just for homogeneity and to get rid of the sonar's bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #809: HDDS-2576. Handle
InterruptedException in OzoneManagerDoubleBuffer
Posted by GitBox <gi...@apache.org>.
elek commented on issue #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/809#issuecomment-615125960
My understanding was wrong. The metric code will be executed all the time, this code just flags the current thread as interrupted and disable the usage of any sleep/wait.
But it's still an open question: it seems to be the normal flow of a shutdown, I don't think that we need to mark the thread itself as interrupted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #809: HDDS-2576. Handle
InterruptedException in OzoneManagerDoubleBuffer
Posted by GitBox <gi...@apache.org>.
elek commented on issue #809: HDDS-2576. Handle InterruptedException in OzoneManagerDoubleBuffer
URL: https://github.com/apache/hadoop-ozone/pull/809#issuecomment-615121993
Thanks to post this patch @danidelvalle
I am trying to understand this part of the code, and it seems to be false positive. As the daemon thread is interrupted right before, I think it's safe to ignore the `InterruptedException`.
Especially as with the proposed approach the metrics (after these lines) won't be stopped.
I am not sure what is the good approach here, I think it's more safe to keep it as is, but I can be convinced...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org