You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by DmytroShkvyra <gi...@git.apache.org> on 2017/05/10 16:02:45 UTC

[GitHub] flink issue #3673: [FLINK-5256] Extend DataSetSingleRowJoin to support Left ...

Github user DmytroShkvyra commented on the issue:

    https://github.com/apache/flink/pull/3673
  
    @fhueske 
    
    > When I tried to change some of the test cases to use inequality predicates (e.g., a < cnt), I notice that these joins are "blocked" by the FlinkLogicalJoinConverter rule.
    
    We should
    
        change that rule to also convert joins that can be translated by the SingleRowJoin (LEFT / RIGHT joins with a single row on the inner side).
        adapt all test cases to use inequality predicates to enforce SingleRowJoins. Some of the current tests will simply use the default join, which is not what we want to test here.
    
    What do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---