You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "vkagamlyk (via GitHub)" <gi...@apache.org> on 2023/10/13 22:29:22 UTC

[PR] [TINKERPOP-2979] added datetime() [tinkerpop]

vkagamlyk opened a new pull request, #2289:
URL: https://github.com/apache/tinkerpop/pull/2289

   Function `datetime()` extended to return current server time when used without argument.
   
   ```
   gremlin> datetime().toGMTString()
   ==>13 Oct 2023 20:44:20 GMT
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2289:
URL: https://github.com/apache/tinkerpop/pull/2289#issuecomment-1769140871

   LGTM, VOTE +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy commented on PR #2289:
URL: https://github.com/apache/tinkerpop/pull/2289#issuecomment-1769252834

   VOTE +1. As a nit aside, should we also update the reference doc part that mentions `datetime()`? I think this was mentioned somewhere under Gremlin Groovy.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

Posted by "xiazcy (via GitHub)" <gi...@apache.org>.
xiazcy merged PR #2289:
URL: https://github.com/apache/tinkerpop/pull/2289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

Posted by "vkagamlyk (via GitHub)" <gi...@apache.org>.
vkagamlyk commented on PR #2289:
URL: https://github.com/apache/tinkerpop/pull/2289#issuecomment-1769538311

   VOTE+1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [TINKERPOP-2979] added datetime() [tinkerpop]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2289:
URL: https://github.com/apache/tinkerpop/pull/2289#issuecomment-1762329987

   ## [Codecov](https://app.codecov.io/gh/apache/tinkerpop/pull/2289?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#2289](https://app.codecov.io/gh/apache/tinkerpop/pull/2289?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (10d9d84) into [master](https://app.codecov.io/gh/apache/tinkerpop/commit/1e3c881d9f157167b53f431898e6d1ee40429cd0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1e3c881) will **decrease** coverage by `4.83%`.
   > Report is 8 commits behind head on master.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2289      +/-   ##
   ============================================
   - Coverage     75.94%   71.11%   -4.83%     
   ============================================
     Files          1060       25    -1035     
     Lines         64353     3895   -60458     
     Branches       7110        0    -7110     
   ============================================
   - Hits          48870     2770   -46100     
   + Misses        12839      934   -11905     
   + Partials       2644      191    -2453     
   ```
   
   
   [see 1035 files with indirect coverage changes](https://app.codecov.io/gh/apache/tinkerpop/pull/2289/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org