[GitHub] [spark] cloud-fan commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition `And` has non-determined sub function it does not do partition prunning

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24118: [SPARK-26736][SQL] if filter condition `And` has non-determined sub function it does not do partition prunning
URL: https://github.com/apache/spark/pull/24118#discussion_r269848499
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
 ##########
 @@ -91,6 +98,54 @@ object PhysicalOperation extends PredicateHelper {
           .map(Alias(_, a.name)(a.exprId, a.qualifier)).getOrElse(a)
     }
   }
+
+  /**
+   * Extract the deterministic expressions in non-deterministic expressions, i.e. 'And' and 'Or'.
+   *
+   * Example input:
+   * {{{
+   *   col = 1 and rand() < 1
+   *   (col1 = 1 and rand() < 1) and col2 = 1
+   *   col1 = 1 or rand() < 1
+   *   (col1 = 1 and rand() < 1) or (col2 = 1 and rand() < 1)
 
 Review comment:
   +1 to be consistent with PushDownPredicate

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org