You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/07/30 06:58:53 UTC
Review Request 24087: Unit test failures on jenkins for Ambari 1.7.0 related
to alerts.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24087/
-----------------------------------------------------------
Review request for Ambari and Nate Cole.
Bugs: AMBARI-6667
https://issues.apache.org/jira/browse/AMBARI-6667
Repository: ambari
Description
-------
Some of the unit tests were failing intermittently. I suspected it had to do with our use of @BeforeClass and JPA initialization. I moved all DAO tests to injected instances before each test.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 4da552f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 91624f2
ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 0258e47
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4b1f4be
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java cf25bd5
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 1366f15
Diff: https://reviews.apache.org/r/24087/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15:26.579s
[INFO] Finished at: Wed Jul 30 00:58:46 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 24087: Unit test failures on jenkins for Ambari 1.7.0
related to alerts.
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24087/#review49103
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On July 30, 2014, 12:58 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24087/
> -----------------------------------------------------------
>
> (Updated July 30, 2014, 12:58 a.m.)
>
>
> Review request for Ambari and Nate Cole.
>
>
> Bugs: AMBARI-6667
> https://issues.apache.org/jira/browse/AMBARI-6667
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Some of the unit tests were failing intermittently. I suspected it had to do with our use of @BeforeClass and JPA initialization. I moved all DAO tests to injected instances before each test.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java 4da552f
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java 91624f2
> ambari-server/src/test/java/org/apache/ambari/server/orm/OrmTestHelper.java 0258e47
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDefinitionDAOTest.java 4b1f4be
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java cf25bd5
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertsDAOTest.java 1366f15
>
> Diff: https://reviews.apache.org/r/24087/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15:26.579s
> [INFO] Finished at: Wed Jul 30 00:58:46 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>