You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2015/10/05 12:19:39 UTC

[2/3] qpid-jms git commit: QPIDJMS-112: remove TODO, answer to question is that we should not update the flag

QPIDJMS-112: remove TODO, answer to question is that we should not update the flag


Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/7a4b73b8
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/7a4b73b8
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/7a4b73b8

Branch: refs/heads/master
Commit: 7a4b73b893d00341d0b1bb74167f86f2067ab9be
Parents: 5f62a8d
Author: Robert Gemmell <ro...@apache.org>
Authored: Mon Oct 5 10:01:29 2015 +0100
Committer: Robert Gemmell <ro...@apache.org>
Committed: Mon Oct 5 10:01:29 2015 +0100

----------------------------------------------------------------------
 .../src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java       | 1 -
 1 file changed, 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/7a4b73b8/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java
index 742ca7a..6500122 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/JmsMessageConsumer.java
@@ -298,7 +298,6 @@ public class JmsMessageConsumer implements MessageConsumer, JmsMessageAvailableC
                         pullForced = true;
                         performPullIfRequired(timeout, true);
                     }
-                    //TODO: do we need to reset pullForced, if there are e.g expired etc messages received and then filtered after the pull?
 
                     // TODO: refresh credit if needed, since the above drains it.
                     //       Processing acks can currently reopen the credit window, but if we don't get a message


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org