You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2020/04/09 23:02:21 UTC
[GitHub] [incubator-gobblin] sv2000 opened a new pull request #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
sv2000 opened a new pull request #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
URL: https://github.com/apache/incubator-gobblin/pull/2951
…ying a HTTP method on transient network errors
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1112
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
We implement a new HTTP method retry handler that allows retrying on transient network errors such as UnknownHostException and NoRouteToHostException.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added unit tests in HttpClientFactoryTest and GobblinHttpMethodRetryHandlerTest classes.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] asfgit closed pull request #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
URL: https://github.com/apache/incubator-gobblin/pull/2951
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-gobblin] codecov-io commented on issue #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #2951: GOBBLIN-1112: Implement a new HttpMethodRetryHandler that allows retr…
URL: https://github.com/apache/incubator-gobblin/pull/2951#issuecomment-613111203
# [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=h1) Report
> Merging [#2951](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gobblin/commit/b64cb3b3442e07b2906dfabe75376e3382fc9457&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `41.93%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2951 +/- ##
============================================
- Coverage 45.55% 44.62% -0.93%
+ Complexity 9160 9004 -156
============================================
Files 1937 1938 +1
Lines 73364 73427 +63
Branches 8100 8111 +11
============================================
- Hits 33420 32767 -653
- Misses 36847 37597 +750
+ Partials 3097 3063 -34
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/gobblin/configuration/ConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29uZmlndXJhdGlvbi9Db25maWd1cmF0aW9uS2V5cy5qYXZh) | `0.00% <ø> (ø)` | `0.00 <0.00> (ø)` | |
| [...gobblin/metrics/kafka/KafkaAvroSchemaRegistry.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3Mva2Fma2EvS2Fma2FBdnJvU2NoZW1hUmVnaXN0cnkuamF2YQ==) | `13.67% <0.00%> (-1.14%)` | `2.00 <0.00> (ø)` | |
| [...kafka/schemareg/GobblinHttpMethodRetryHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3NjaGVtYXJlZy9Hb2JibGluSHR0cE1ldGhvZFJldHJ5SGFuZGxlci5qYXZh) | `46.15% <46.15%> (ø)` | `4.00 <4.00> (?)` | |
| [...che/gobblin/kafka/schemareg/HttpClientFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3NjaGVtYXJlZy9IdHRwQ2xpZW50RmFjdG9yeS5qYXZh) | `65.00% <77.77%> (+28.63%)` | `2.00 <1.00> (+2.00)` | |
| [...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh) | `0.00% <0.00%> (-83.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=) | `0.00% <0.00%> (-80.77%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lin/runtime/locks/LegacyJobLockFactoryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvTGVnYWN5Sm9iTG9ja0ZhY3RvcnlNYW5hZ2VyLmphdmE=) | `0.00% <0.00%> (-78.58%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [51 more](https://codecov.io/gh/apache/incubator-gobblin/pull/2951/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=footer). Last update [b64cb3b...c473fec](https://codecov.io/gh/apache/incubator-gobblin/pull/2951?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services