You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/01 05:43:00 UTC
[jira] [Commented] (NIFI-5776) ListSFTP should log SSH_FXP_STATUS
id value
[ https://issues.apache.org/jira/browse/NIFI-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16671137#comment-16671137 ]
ASF GitHub Bot commented on NIFI-5776:
--------------------------------------
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/3120
NIFI-5776: ListSFTP should log SSH_FXP_STATUS id value
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-5776
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/3120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3120
----
commit c1684bbbfe7f2bd0085af22d3f6eb23b89181570
Author: Koji Kawamura <ij...@...>
Date: 2018-11-01T05:41:06Z
NIFI-5776: ListSFTP should log SSH_FXP_STATUS id value
----
> ListSFTP should log SSH_FXP_STATUS id value
> -------------------------------------------
>
> Key: NIFI-5776
> URL: https://issues.apache.org/jira/browse/NIFI-5776
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
> Affects Versions: 1.0.0
> Reporter: Koji Kawamura
> Assignee: Koji Kawamura
> Priority: Minor
>
> When SSH_FXP_READDIR request is sent, if SSH_FXP_STATUS other than the expected SSH_FX_EOF is returned, SftpException is thrown. Current catch block converts the exception into different exceptions based on SSH_FXP_STATUS id. But if the id is not SSH_FX_NO_SUCH_FILE or SSH_FX_PERMISSION_DENIED, the returned id won't be logged. That makes it hard to investigate issues for such code.
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/util/SFTPTransfer.java#L263
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)