[GitHub] [hive] abstractdog commented on pull request #2236: HIVE-25082: Make updateTimezone a default method on SettableTreeReader

[GitBox <gi...@apache.org>]

abstractdog commented on pull request #2236:
URL: https://github.com/apache/hive/pull/2236#issuecomment-831124035


   I'm not 100% certain about this patch in this form, but I understand your intention
   from the caller side, it's much cleaner to remove the cast, but from the interface side, it looks more like interface pollution, especially because we're adding a timestamp-only method to the interface, which is certainly not going to be implemented by most of the classes...I would like this as any of the 2 ways below:
   1. doing the update in the setBuffers call like setBuffers(batch, sameStripe, stripeMetadata)
   2. having a more general method on the interface instead of updateTimezone: anyNameYouWant(stripeMetadata) <- maybe we can reuse this method later


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org