You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomee.apache.org by "ralf.battenfeld@bluewin.ch" <ra...@bluewin.ch> on 2013/05/26 15:12:08 UTC

Patch for: Validation: @ConcurrencyManagement mistakenly used on non-Singleton

Hi

I synchronized the validation for invalid ConcurrencyManagement annotation which I wrote weeks ago with the latest 
trunk. I hope this is the way of submitting patches. If not, let me know.  
I had problems to execute a full build. 
Within eclipse the validation test for this check passes.

The JIRA task is: OPENEJB-453 Validation for EJB 3.0 beans / 
OPENEJB-849

Let me know if there are issues or things I have to improve.

Thanks
Ralf

Re: Patch for: Validation: @ConcurrencyManagement mistakenly used on non-Singleton

Posted by dsh <da...@gmail.com>.
Simply reverse the order you provide the tomee/tomee-new directories. That
should fix the issue. In the end you should have plus instead of minus
symbols for your newly added code in the patch output file.

Cheers
Daniel


On Sun, May 26, 2013 at 9:21 PM, <ra...@bluewin.ch> wrote:

> Hi Romain, I will double check when I am back. Your comment lets my think
> that I made mistake with the diff command. It should add the validator and
> not remove.
>
> Thanks for informing me.
> Ralf
>
>
> On 26.05.13 20:38 Romain Manni-Bucau wrote:
>
> hi
>
>
> is the patch correct? it removes what you want to add no?
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
>
>
>
> 2013/5/26 ralf.battenfeld@bluewin.ch <ra...@bluewin.ch>
>
> Hi
>
> I synchronized the validation for invalid ConcurrencyManagement annotation
> which I wrote weeks ago with the latest
> trunk. I hope this is the way of submitting patches. If not, let me know.
> I had problems to execute a full build.
> Within eclipse the validation test for this check passes.
>
> The JIRA task is: OPENEJB-453 Validation for EJB 3.0 beans /
> OPENEJB-849
>
> Let me know if there are issues or things I have to improve.
>
> Thanks
> Ralf
>
>
>
>
>
>

Re: Patch for: Validation: @ConcurrencyManagement mistakenly used on non-Singleton

Posted by ra...@bluewin.ch.
Hi Romain, I will double check when I am back. Your comment lets my think that I made mistake with the diff command. It should add the validator and not remove.

Thanks for informing me.
Ralf


On 26.05.13 20:38 Romain Manni-Bucau wrote:

hi


is the patch correct? it removes what you want to add no?


Romain Manni-Bucau
Twitter: @rmannibucau 
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau 
Github: https://github.com/rmannibucau





2013/5/26 ralf.battenfeld@bluewin.ch <ra...@bluewin.ch>

Hi

I synchronized the validation for invalid ConcurrencyManagement annotation which I wrote weeks ago with the latest
trunk. I hope this is the way of submitting patches. If not, let me know.
I had problems to execute a full build.
Within eclipse the validation test for this check passes.

The JIRA task is: OPENEJB-453 Validation for EJB 3.0 beans /
OPENEJB-849

Let me know if there are issues or things I have to improve.

Thanks
Ralf

Re: Patch for: Validation: @ConcurrencyManagement mistakenly used on non-Singleton

Posted by Romain Manni-Bucau <rm...@gmail.com>.
hi

is the patch correct? it removes what you want to add no?

*Romain Manni-Bucau*
*Twitter: @rmannibucau <https://twitter.com/rmannibucau>*
*Blog: **http://rmannibucau.wordpress.com/*<http://rmannibucau.wordpress.com/>
*LinkedIn: **http://fr.linkedin.com/in/rmannibucau*
*Github: https://github.com/rmannibucau*



2013/5/26 ralf.battenfeld@bluewin.ch <ra...@bluewin.ch>

> Hi
>
> I synchronized the validation for invalid ConcurrencyManagement annotation
> which I wrote weeks ago with the latest
> trunk. I hope this is the way of submitting patches. If not, let me know.
> I had problems to execute a full build.
> Within eclipse the validation test for this check passes.
>
> The JIRA task is: OPENEJB-453 Validation for EJB 3.0 beans /
> OPENEJB-849
>
> Let me know if there are issues or things I have to improve.
>
> Thanks
> Ralf
>
>