You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 15:17:10 UTC
[GitHub] [airflow] potiuk opened a new pull request #13862: Update wording in upgrading documentation
potiuk opened a new pull request #13862:
URL: https://github.com/apache/airflow/pull/13862
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vikramkoka commented on a change in pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
vikramkoka commented on a change in pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#discussion_r565731061
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -286,10 +286,18 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
.. warning::
Breaking change
- Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
- RBAC UI explicitly in the configuration now as this is the only default UI. We did it to avoid
- the huge maintenance burden of two independent user interfaces
+ Previously we were using two versions of the UI:
+ - non-RBAC UI
+ - Flask App Builder RBAC UI
+
+ This was difficult to maintain, because it meant we
+ had to implement/update features in two places. With this release, we have removed the older UI in
+ favor of the Flask App Builder RBAC UI, reducing a huge maintenance burden.
+ There is no longer a need to set the RBAC UI explicitly in the configuration,
+ as it is the only default UI.
+
+ If you previously used non-RBAC UI, you have to switch to the new RBAC-ui and create users to be able
+ to access Airflow's webserver. For more details on CLI to create users see :doc:`cli-and-env-variables-ref`
Review comment:
```suggestion
If you previously used non-RBAC UI, you have to switch to the new RBAC-UI and create users to be able
to access Airflow's webserver. For more details on CLI to create users see :doc:`cli-and-env-variables-ref`
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#discussion_r563289407
##########
File path: docs/apache-airflow/upgrading-to-2.rst
##########
@@ -286,10 +286,14 @@ When DAGs are initialized with the ``access_control`` variable set, any usage of
.. warning::
Breaking change
- Previously we were using two versions of UI, which were hard to maintain as we need to implement/update the same feature
- in both versions. With this release we've removed the older UI in favor of Flask App Builder RBAC UI. No need to set the
- RBAC UI explicitly in the configuration now as this is the only default UI. We did it to avoid
- the huge maintenance burden of two independent user interfaces
+ Previously we were using two versions of the UI. This was difficult to maintain, because it meant we
Review comment:
```suggestion
Previously we were using two versions of the UI:
- non-RBAC UI
- Flask App Builder RBAC UI
This was difficult to maintain, because it meant we
```
Should we say explicitly what were the two versions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#issuecomment-766100254
[The Workflow run](https://github.com/apache/airflow/actions/runs/505947225) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#issuecomment-766095664
[The Workflow run](https://github.com/apache/airflow/actions/runs/505928695) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#issuecomment-770449666
Updated @vikramkoka !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #13862:
URL: https://github.com/apache/airflow/pull/13862
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13862: Update wording in upgrading documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13862:
URL: https://github.com/apache/airflow/pull/13862#issuecomment-770690024
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org