You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/05/02 17:49:12 UTC

[GitHub] [fineract] vidakovic commented on a diff in pull request #2310: FINERACT-1609: Added Pagination to reports

vidakovic commented on code in PR #2310:
URL: https://github.com/apache/fineract/pull/2310#discussion_r863052590


##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/data/GenericResultsetData.java:
##########
@@ -27,10 +27,15 @@ public final class GenericResultsetData {
 
     private final List<ResultsetColumnHeaderData> columnHeaders;
     private final List<ResultsetRowData> data;
+    private Integer totalReportSize;

Review Comment:
   ... the class is called "GenericResultsetData"... is it then really necessary to have the word "report" in this variable? We could name things like in Spring Data... just a suggestion.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org