You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/03/01 06:50:47 UTC
[GitHub] [incubator-doris] BiteTheDDDDt opened a new pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
BiteTheDDDDt opened a new pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282
# Proposed changes
@HappenLee
Issue Number: close #8281
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282#issuecomment-1056562074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] BiteTheDDDDt commented on a change in pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
Posted by GitBox <gi...@apache.org>.
BiteTheDDDDt commented on a change in pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282#discussion_r817302755
##########
File path: be/src/vec/core/block.cpp
##########
@@ -720,12 +720,9 @@ Status Block::serialize(PBlock* pblock, size_t* uncompressed_bytes, size_t* comp
// serialize data values
allocated_buf->resize(content_uncompressed_size);
char* buf = allocated_buf->data();
- char* start_buf = buf;
for (const auto& c : *this) {
buf = c.type->serialize(*(c.column), buf);
}
- CHECK(content_uncompressed_size == (buf - start_buf))
Review comment:
When data type is HLL, content_uncompressed_size maybe larger than real size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #8282: [Bug] fix string type length limit error && add runtime filter decimal support
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #8282:
URL: https://github.com/apache/incubator-doris/pull/8282#discussion_r816845580
##########
File path: be/src/vec/core/block.cpp
##########
@@ -720,12 +720,9 @@ Status Block::serialize(PBlock* pblock, size_t* uncompressed_bytes, size_t* comp
// serialize data values
allocated_buf->resize(content_uncompressed_size);
char* buf = allocated_buf->data();
- char* start_buf = buf;
for (const auto& c : *this) {
buf = c.type->serialize(*(c.column), buf);
}
- CHECK(content_uncompressed_size == (buf - start_buf))
Review comment:
why remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org