You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by sr...@apache.org on 2016/04/12 04:24:32 UTC
spark git commit: [MINOR][ML] Fixed MLlib build warnings
Repository: spark
Updated Branches:
refs/heads/master 26d7af911 -> e9e1adc03
[MINOR][ML] Fixed MLlib build warnings
## What changes were proposed in this pull request?
Fixes to eliminate warnings during package and doc builds.
## How was this patch tested?
Existing unit tests
Author: Joseph K. Bradley <jo...@databricks.com>
Closes #12263 from jkbradley/warning-cleanups.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e9e1adc0
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e9e1adc0
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e9e1adc0
Branch: refs/heads/master
Commit: e9e1adc036643c6b126237903b8e79ab379b1d32
Parents: 26d7af9
Author: Joseph K. Bradley <jo...@databricks.com>
Authored: Tue Apr 12 03:24:26 2016 +0100
Committer: Sean Owen <so...@cloudera.com>
Committed: Tue Apr 12 03:24:26 2016 +0100
----------------------------------------------------------------------
.../spark/examples/mllib/JavaStratifiedSamplingExample.java | 1 +
.../scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala | 3 +++
2 files changed, 4 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/e9e1adc0/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
----------------------------------------------------------------------
diff --git a/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java b/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
index 86c389e..72bbb2a 100644
--- a/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
+++ b/examples/src/main/java/org/apache/spark/examples/mllib/JavaStratifiedSamplingExample.java
@@ -35,6 +35,7 @@ public class JavaStratifiedSamplingExample {
SparkConf conf = new SparkConf().setAppName("JavaStratifiedSamplingExample");
JavaSparkContext jsc = new JavaSparkContext(conf);
+ @SuppressWarnings("unchecked")
// $example on$
List<Tuple2<Integer, Character>> list = new ArrayList<>(
Arrays.<Tuple2<Integer, Character>>asList(
http://git-wip-us.apache.org/repos/asf/spark/blob/e9e1adc0/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala
----------------------------------------------------------------------
diff --git a/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala b/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala
index e64551f..cd402b1 100644
--- a/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala
+++ b/mllib/src/test/scala/org/apache/spark/ml/tree/impl/RandomForestSuite.scala
@@ -327,7 +327,9 @@ class RandomForestSuite extends SparkFunSuite with MLlibTestSparkContext {
case n: InternalNode => n.split match {
case s: CategoricalSplit =>
assert(s.leftCategories === Array(1.0))
+ case _ => throw new AssertionError("model.rootNode.split was not a CategoricalSplit")
}
+ case _ => throw new AssertionError("model.rootNode was not an InternalNode")
}
}
@@ -352,6 +354,7 @@ class RandomForestSuite extends SparkFunSuite with MLlibTestSparkContext {
assert(n.leftChild.isInstanceOf[InternalNode])
assert(n.rightChild.isInstanceOf[InternalNode])
Array(n.leftChild.asInstanceOf[InternalNode], n.rightChild.asInstanceOf[InternalNode])
+ case _ => throw new AssertionError("rootNode was not an InternalNode")
}
// Single group second level tree construction.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org