You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by radarwave <gi...@git.apache.org> on 2017/03/29 03:13:28 UTC
[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...
GitHub user radarwave opened a pull request:
https://github.com/apache/incubator-hawq/pull/1207
HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for rpm build.
This fix included:
1) Fixed HAWQ_RELEASE_VERSION for rpm tarball.
2) Make sure distclean delete all the rpm artifacts.
3) Added some log output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/radarwave/incubator-hawq rpmfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/1207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1207
----
commit a8680673ea03a400fdf0653570fd83f358fcbbbb
Author: rlei <rl...@pivotal.io>
Date: 2017-03-28T14:19:29Z
HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for rpm build.
This fix included:
1) Fixed HAWQ_RELEASE_VERSION for rpm tarball.
2) Make sure distclean delete all the rpm artifacts.
3) Added some log output.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/1207
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERSION for...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/1207
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1207#discussion_r108593718
--- Diff: contrib/hawq-package/build_hawq_rpm.sh ---
@@ -71,8 +76,14 @@ rpmbuild --define "_topdir ${RPM_TOP_DIR}" \
-bb SPECS/hawq.spec
if [ $? != 0 ]; then
echo "Build HAWQ rpm package failed, exit..."
- exit 0
+ exit 1
fi
set +x
popd > /dev/null
+
+echo "========================================================================="
+echo "Build HAWQ rpm package successfully."
--- End diff --
Good point! Fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1207#discussion_r108589872
--- Diff: contrib/hawq-package/build_hawq_rpm.sh ---
@@ -71,8 +76,14 @@ rpmbuild --define "_topdir ${RPM_TOP_DIR}" \
-bb SPECS/hawq.spec
if [ $? != 0 ]; then
echo "Build HAWQ rpm package failed, exit..."
- exit 0
+ exit 1
fi
set +x
popd > /dev/null
+
+echo "========================================================================="
+echo "Build HAWQ rpm package successfully."
--- End diff --
Maybe we should tell users where the rpm package is?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/1207#discussion_r108589856
--- Diff: contrib/hawq-package/build_hawq_rpm.sh ---
@@ -71,8 +76,14 @@ rpmbuild --define "_topdir ${RPM_TOP_DIR}" \
-bb SPECS/hawq.spec
if [ $? != 0 ]; then
echo "Build HAWQ rpm package failed, exit..."
- exit 0
+ exit 1
--- End diff --
Why not "exit $?"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #1207: HAWQ-326. Fix specified HAWQ_RELEASE_VERS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/1207
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---